While set polarity, we should keep the disconnected cc line to be
open when attached.

Signed-off-by: Li Jun <jun...@nxp.com>
---
Change for v2:
- Set the uncontact cc line to be open when set polarity, this way,
  we don't need change set_cc api.

 drivers/staging/typec/tcpci.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 530a5d7..7145771 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -184,6 +184,7 @@ static int tcpci_set_polarity(struct tcpc_dev *tcpc,
                              enum typec_cc_polarity polarity)
 {
        struct tcpci *tcpci = tcpc_to_tcpci(tcpc);
+       unsigned int reg;
        int ret;
 
        ret = regmap_write(tcpci->regmap, TCPC_TCPC_CTRL,
@@ -192,6 +193,20 @@ static int tcpci_set_polarity(struct tcpc_dev *tcpc,
        if (ret < 0)
                return ret;
 
+       ret = regmap_read(tcpci->regmap, TCPC_ROLE_CTRL, &reg);
+       if (ret < 0)
+               return ret;
+
+       if (polarity == TYPEC_POLARITY_CC2)
+               ret = TCPC_ROLE_CTRL_CC1_SHIFT;
+       else
+               ret = TCPC_ROLE_CTRL_CC2_SHIFT;
+       reg |= TCPC_ROLE_CTRL_CC_OPEN << ret;
+       reg &= ~TCPC_ROLE_CTRL_DRP;
+       ret = regmap_write(tcpci->regmap, TCPC_ROLE_CTRL, reg);
+       if (ret < 0)
+               return ret;
+
        return 0;
 }
 
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to