Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore

Hi Kai-Heng, Thank you for the patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.16-rc3 next-20180226] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore

On Sun, Feb 25, 2018 at 11:18 PM, Matthew Wilcox wrote: > On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote: >> v2: Use in-kernel tolower() function. > > ... why are you using tolower at all? > > You've got 13 quirks already; you may need to use upper case as well

Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore

On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote: > v2: Use in-kernel tolower() function. ... why are you using tolower at all? You've got 13 quirks already; you may need to use upper case as well before too long. > + quirk = vmalloc(sizeof(struct quirk_entry));

[PATCH v3] usb: core: Add "quirks" parameter for usbcore

Trying quirks in usbcore needs to rebuild the driver or the entire kernel if it's builtin. It can save a lot of time if usbcore has similar ability like "usbhid.quirks=" and "usb-storage.quirks=". Rename the original quirk detection function to "static" as we introduce this new "dynamic"