RE: [PATCH v3 1/2] usbip: vhci number of ports extension

2016-02-14 Thread fx IWATA NOBUO
> > ex) # insmod vhci_hcd.ko num_controllers=4 > > I hate module parameters, please don't do that, create these dynamically > as needed some other way. OK. > > Also, ports per controller is changed from 8 to USB_MAXCHILDREN (31). > > Why? All in one patch? Not good. I will remove the

Re: [PATCH v3 1/2] usbip: vhci number of ports extension

2016-02-14 Thread Greg KH
On Wed, Feb 10, 2016 at 10:55:12AM +0900, Nobuo Iwata wrote: > This patch extends number of ports limitation in application (vhci) > side. > > To do so, vhci driver supports multiple host controllers. The number of > controllers can be specified as a module parameter 'num_controllers'. > The

[PATCH v3 1/2] usbip: vhci number of ports extension

2016-02-09 Thread Nobuo Iwata
This patch extends number of ports limitation in application (vhci) side. To do so, vhci driver supports multiple host controllers. The number of controllers can be specified as a module parameter 'num_controllers'. The default is 1. ex) # insmod vhci_hcd.ko num_controllers=4 Also, ports per