Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

Hi Kai-Heng, Thank you for the patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.16-rc3 next-20180228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

Hi Kai-Heng, Thank you for the patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.16-rc3 next-20180228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

On Thu, Mar 01, 2018 at 12:01:40AM +0800, Kai Heng Feng wrote: > > Also, you won't need to use a linked list for this; you can just allocate > > an array of quirks. > > I use linked list because the total quirks number is known after the entire > string gets parsed. > Do you suggest that I should

Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

On 28 Feb 2018, at 10:47 PM, Matthew Wilcox wrote: On Mon, Feb 26, 2018 at 11:04:57PM +0800, Kai-Heng Feng wrote: +static char quirks_param[128]; +module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644); +MODULE_PARM_DESC(quirks, "Add/modify USB quirks by

Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

On Mon, Feb 26, 2018 at 11:04:57PM +0800, Kai-Heng Feng wrote: > +static char quirks_param[128]; > +module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644); > +MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying > quirks=vendorID:productID:quirks"); > + > +static char

[PATCH v4] usb: core: Add "quirks" parameter for usbcore

Trying quirks in usbcore needs to rebuild the driver or the entire kernel if it's builtin. It can save a lot of time if usbcore has similar ability like "usbhid.quirks=" and "usb-storage.quirks=". Rename the original quirk detection function to "static" as we introduce this new "dynamic"