Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-07-15 Thread Kishon Vijay Abraham I
Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init and disable them on phy_exit. 2) It has bits to signal id and vbus

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-07-15 Thread Kishon Vijay Abraham I
On Wednesday 15 July 2015 04:25 PM, Kishon Vijay Abraham I wrote: Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Kishon Vijay Abraham I
Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init and disable them on phy_exit. 2) It has bits to signal id and vbus detect

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
On 06/11/2015 06:33 PM, Chanwoo Choi wrote: Hi, On 06/11/2015 05:59 PM, Hans de Goede wrote: Hi, On 11-06-15 10:29, Chanwoo Choi wrote: Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
Hi, On 06/11/2015 06:38 PM, Hans de Goede wrote: Hi, On 11-06-15 11:33, Chanwoo Choi wrote: Hi, On 06/11/2015 05:59 PM, Hans de Goede wrote: Hi, On 11-06-15 10:29, Chanwoo Choi wrote: Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review.

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
Hi, On 06/11/2015 05:59 PM, Hans de Goede wrote: Hi, On 11-06-15 10:29, Chanwoo Choi wrote: Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I add the comment about extcon-related code.

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 10:29, Chanwoo Choi wrote: Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I add the comment about extcon-related code. Firstly, I'd like you to implment the extcon driver for

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 11:42, Kishon Vijay Abraham I wrote: Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init and disable them on

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Kishon Vijay Abraham I
Hi, On Thursday 11 June 2015 03:23 PM, Hans de Goede wrote: Hi, On 11-06-15 11:42, Kishon Vijay Abraham I wrote: Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Kishon Vijay Abraham I
On Thursday 11 June 2015 06:05 PM, Hans de Goede wrote: Hi, On 11-06-15 13:16, Kishon Vijay Abraham I wrote: Hi, On Thursday 11 June 2015 03:23 PM, Hans de Goede wrote: Hi, On 11-06-15 11:42, Kishon Vijay Abraham I wrote: Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 13:16, Kishon Vijay Abraham I wrote: Hi, On Thursday 11 June 2015 03:23 PM, Hans de Goede wrote: Hi, On 11-06-15 11:42, Kishon Vijay Abraham I wrote: Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 07:48, Kishon Vijay Abraham I wrote: +Chanwoo Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init and

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
Hi Hans, I add the comment about extcon-related code. Firstly, I'd like you to implment the extcon driver for phy-sun4i-usb device in drivers/extcon/ directoryby using MFD because there are both extcon provider driver and extcon client driver. I think that all extcon provider driver better to be

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I add the comment about extcon-related code. Firstly, I'd like you to implment the extcon driver for phy-sun4i-usb device in drivers/extcon/ directoryby using MFD No, just no, this is not what the MFD

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I add the comment about extcon-related code. Firstly, I'd like you to implment the extcon driver for phy-sun4i-usb device in drivers/extcon/

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 09:56, Hans de Goede wrote: Hi, On 11-06-15 07:48, Kishon Vijay Abraham I wrote: +Chanwoo Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-10 Thread Kishon Vijay Abraham I
+Chanwoo Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init and disable them on phy_exit. 2) It has bits to signal id and

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-02 Thread Maxime Ripard
Hi, On Mon, Jun 01, 2015 at 11:28:23AM +0200, Hans de Goede wrote: On 01-06-15 11:22, Maxime Ripard wrote: On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote: + /* We either want both gpio pins or neither (when in host mode) */ + if (!data-id_det_gpio != !data-vbus_det_gpio) {

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-01 Thread Maxime Ripard
On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote: + /* We either want both gpio pins or neither (when in host mode) */ + if (!data-id_det_gpio != !data-vbus_det_gpio) { + dev_err(dev, failed to get id or vbus detect pin\n); + return -ENODEV; +

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-01 Thread Hans de Goede
Hi, On 01-06-15 11:22, Maxime Ripard wrote: On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote: + /* We either want both gpio pins or neither (when in host mode) */ + if (!data-id_det_gpio != !data-vbus_det_gpio) { + dev_err(dev, failed to get id or vbus

[PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-05-31 Thread Hans de Goede
The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init and disable them on phy_exit. 2) It has bits to signal id and vbus detect to the musb-core, add support for for monitoring id and vbus