Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs some special
handling:
1) It allows explicit control over the pullups, enable these on phy_init and
disable them on phy_exit.
2) It has bits to signal id and vbus
On Wednesday 15 July 2015 04:25 PM, Kishon Vijay Abraham I wrote:
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs some
special
handling:
1) It allows explicit control over the pullups, enable these on phy_init
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs some special
handling:
1) It allows explicit control over the pullups, enable these on phy_init and
disable them on phy_exit.
2) It has bits to signal id and vbus detect
On 06/11/2015 06:33 PM, Chanwoo Choi wrote:
Hi,
On 06/11/2015 05:59 PM, Hans de Goede wrote:
Hi,
On 11-06-15 10:29, Chanwoo Choi wrote:
Hi Hans,
On 06/11/2015 05:21 PM, Hans de Goede wrote:
Hi Chanwoo,
Thanks for the quick review.
On 11-06-15 10:07, Chanwoo Choi wrote:
Hi Hans,
I
Hi,
On 06/11/2015 06:38 PM, Hans de Goede wrote:
Hi,
On 11-06-15 11:33, Chanwoo Choi wrote:
Hi,
On 06/11/2015 05:59 PM, Hans de Goede wrote:
Hi,
On 11-06-15 10:29, Chanwoo Choi wrote:
Hi Hans,
On 06/11/2015 05:21 PM, Hans de Goede wrote:
Hi Chanwoo,
Thanks for the quick review.
Hi,
On 06/11/2015 05:59 PM, Hans de Goede wrote:
Hi,
On 11-06-15 10:29, Chanwoo Choi wrote:
Hi Hans,
On 06/11/2015 05:21 PM, Hans de Goede wrote:
Hi Chanwoo,
Thanks for the quick review.
On 11-06-15 10:07, Chanwoo Choi wrote:
Hi Hans,
I add the comment about extcon-related code.
Hi,
On 11-06-15 10:29, Chanwoo Choi wrote:
Hi Hans,
On 06/11/2015 05:21 PM, Hans de Goede wrote:
Hi Chanwoo,
Thanks for the quick review.
On 11-06-15 10:07, Chanwoo Choi wrote:
Hi Hans,
I add the comment about extcon-related code.
Firstly,
I'd like you to implment the extcon driver for
Hi,
On 11-06-15 11:42, Kishon Vijay Abraham I wrote:
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs some special
handling:
1) It allows explicit control over the pullups, enable these on phy_init and
disable them on
Hi,
On Thursday 11 June 2015 03:23 PM, Hans de Goede wrote:
Hi,
On 11-06-15 11:42, Kishon Vijay Abraham I wrote:
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs some special
handling:
1) It allows explicit control
On Thursday 11 June 2015 06:05 PM, Hans de Goede wrote:
Hi,
On 11-06-15 13:16, Kishon Vijay Abraham I wrote:
Hi,
On Thursday 11 June 2015 03:23 PM, Hans de Goede wrote:
Hi,
On 11-06-15 11:42, Kishon Vijay Abraham I wrote:
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The
Hi,
On 11-06-15 13:16, Kishon Vijay Abraham I wrote:
Hi,
On Thursday 11 June 2015 03:23 PM, Hans de Goede wrote:
Hi,
On 11-06-15 11:42, Kishon Vijay Abraham I wrote:
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs
Hi,
On 11-06-15 07:48, Kishon Vijay Abraham I wrote:
+Chanwoo
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs some special
handling:
1) It allows explicit control over the pullups, enable these on phy_init and
Hi Hans,
I add the comment about extcon-related code.
Firstly,
I'd like you to implment the extcon driver for phy-sun4i-usb device
in drivers/extcon/ directoryby using MFD because there are both extcon
provider driver and extcon client driver. I think that all extcon
provider driver better to be
Hi Chanwoo,
Thanks for the quick review.
On 11-06-15 10:07, Chanwoo Choi wrote:
Hi Hans,
I add the comment about extcon-related code.
Firstly,
I'd like you to implment the extcon driver for phy-sun4i-usb device
in drivers/extcon/ directoryby using MFD
No, just no, this is not what the MFD
Hi Hans,
On 06/11/2015 05:21 PM, Hans de Goede wrote:
Hi Chanwoo,
Thanks for the quick review.
On 11-06-15 10:07, Chanwoo Choi wrote:
Hi Hans,
I add the comment about extcon-related code.
Firstly,
I'd like you to implment the extcon driver for phy-sun4i-usb device
in drivers/extcon/
Hi,
On 11-06-15 09:56, Hans de Goede wrote:
Hi,
On 11-06-15 07:48, Kishon Vijay Abraham I wrote:
+Chanwoo
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs some special
handling:
1) It allows explicit control over
+Chanwoo
Hi,
On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote:
The usb0 phy is connected to an OTG controller, and as such needs some special
handling:
1) It allows explicit control over the pullups, enable these on phy_init and
disable them on phy_exit.
2) It has bits to signal id and
Hi,
On Mon, Jun 01, 2015 at 11:28:23AM +0200, Hans de Goede wrote:
On 01-06-15 11:22, Maxime Ripard wrote:
On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote:
+ /* We either want both gpio pins or neither (when in host mode) */
+ if (!data-id_det_gpio != !data-vbus_det_gpio) {
On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote:
+ /* We either want both gpio pins or neither (when in host mode) */
+ if (!data-id_det_gpio != !data-vbus_det_gpio) {
+ dev_err(dev, failed to get id or vbus detect pin\n);
+ return -ENODEV;
+
Hi,
On 01-06-15 11:22, Maxime Ripard wrote:
On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote:
+ /* We either want both gpio pins or neither (when in host mode) */
+ if (!data-id_det_gpio != !data-vbus_det_gpio) {
+ dev_err(dev, failed to get id or vbus
The usb0 phy is connected to an OTG controller, and as such needs some special
handling:
1) It allows explicit control over the pullups, enable these on phy_init and
disable them on phy_exit.
2) It has bits to signal id and vbus detect to the musb-core, add support for
for monitoring id and vbus
21 matches
Mail list logo