Re: [PATCH v4 3/7] phy: Add set_mode callback

2016-05-09 Thread David Lechner
On 05/04/2016 01:39 PM, Bin Liu wrote: On Wed, May 04, 2016 at 01:20:36PM -0500, David Lechner wrote: This is something I actually plan on using because the device I am using (LEGO MINDSTORMS EV3) is not wired for OTG, so the callback is needed to override the ID and VBUS signals when switching

Re: [PATCH v4 3/7] phy: Add set_mode callback

2016-05-04 Thread David Lechner
On 05/04/2016 01:39 PM, Bin Liu wrote: Have you already tested this? I never tried changing mode via sysfs, but by quickly reviewing the code, I am wondering how it works. the core only calls ops->set_mode() but nothing else. To really switch the mode, the driver has to talk to the root hub,

Re: [PATCH v4 3/7] phy: Add set_mode callback

2016-05-04 Thread Bin Liu
On Wed, May 04, 2016 at 01:20:36PM -0500, David Lechner wrote: > On 05/04/2016 01:10 PM, Bin Liu wrote: > >Hi, > > > >On Thu, Apr 14, 2016 at 01:35:14PM -0500, David Lechner wrote: > >>The initial use for this is for PHYs that have a mode related to USB OTG. > >>There are several SoCs (e.g. TI

Re: [PATCH v4 3/7] phy: Add set_mode callback

2016-05-04 Thread David Lechner
On 05/04/2016 01:10 PM, Bin Liu wrote: Hi, On Thu, Apr 14, 2016 at 01:35:14PM -0500, David Lechner wrote: The initial use for this is for PHYs that have a mode related to USB OTG. There are several SoCs (e.g. TI OMAP and DA8xx) that have a mode setting in the USB PHY to override OTG VBUS and

Re: [PATCH v4 3/7] phy: Add set_mode callback

2016-05-04 Thread Bin Liu
Hi, On Thu, Apr 14, 2016 at 01:35:14PM -0500, David Lechner wrote: > The initial use for this is for PHYs that have a mode related to USB OTG. > There are several SoCs (e.g. TI OMAP and DA8xx) that have a mode setting > in the USB PHY to override OTG VBUS and ID signals. > > Of course, the enum

[PATCH v4 3/7] phy: Add set_mode callback

2016-04-14 Thread David Lechner
The initial use for this is for PHYs that have a mode related to USB OTG. There are several SoCs (e.g. TI OMAP and DA8xx) that have a mode setting in the USB PHY to override OTG VBUS and ID signals. Of course, the enum can be expaned in the future to include modes for other types of PHYs as well.