Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-29 Thread Heiko Stuebner
Hi Kishon, Am Mittwoch, 29. Juni 2016, 19:44:52 schrieb Kishon Vijay Abraham I: > On Friday 17 June 2016 10:16 PM, Heiko Stübner wrote: > > Am Freitag, 17. Juni 2016, 17:24:46 schrieb Kishon Vijay Abraham I: > > [...] > > > >>> + /* find out a proper config which can be matched with dt. */ > >>>

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-29 Thread Kishon Vijay Abraham I
Hi, On Friday 17 June 2016 10:16 PM, Heiko Stübner wrote: > Hi Kishon, > > Am Freitag, 17. Juni 2016, 17:24:46 schrieb Kishon Vijay Abraham I: > >>> + ret = of_clk_add_provider(node, of_clk_src_simple_get, rphy->clk480m); >>> + if (ret < 0) >>> + goto err_clk_provider; >>> + >>> +

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-17 Thread Heiko Stübner
Hi Kishon, Am Freitag, 17. Juni 2016, 17:24:46 schrieb Kishon Vijay Abraham I: > > + ret = of_clk_add_provider(node, of_clk_src_simple_get, rphy->clk480m); > > + if (ret < 0) > > + goto err_clk_provider; > > + > > + ret = devm_add_action(rphy->dev,

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-17 Thread Kishon Vijay Abraham I
Hi, On Monday 13 June 2016 07:40 AM, Frank Wang wrote: > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > than rk3288 and before, and most of phy-related registers are also > different from the past, so a new phy driver is required necessarily. > > Signed-off-by: Frank Wang

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-16 Thread Frank Wang
Hi Guenter, On 2016/6/16 21:12, Guenter Roeck wrote: On 06/15/2016 06:47 PM, Frank Wang wrote: Hi Guenter & Heiko, On 2016/6/15 23:47, Guenter Roeck wrote: On Tue, Jun 14, 2016 at 6:14 PM, Frank Wang wrote: Hi Heiko & Guenter, On 2016/6/14 22:00, Heiko Stübner

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-16 Thread Guenter Roeck
On 06/15/2016 06:47 PM, Frank Wang wrote: Hi Guenter & Heiko, On 2016/6/15 23:47, Guenter Roeck wrote: On Tue, Jun 14, 2016 at 6:14 PM, Frank Wang wrote: Hi Heiko & Guenter, On 2016/6/14 22:00, Heiko Stübner wrote: Am Dienstag, 14. Juni 2016, 06:50:31 schrieb

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-15 Thread Frank Wang
Hi Guenter & Heiko, On 2016/6/15 23:47, Guenter Roeck wrote: On Tue, Jun 14, 2016 at 6:14 PM, Frank Wang wrote: Hi Heiko & Guenter, On 2016/6/14 22:00, Heiko Stübner wrote: Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck: On Tue, Jun 14, 2016 at 6:27

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-15 Thread Heiko Stübner
Hi Frank, Am Mittwoch, 15. Juni 2016, 18:58:43 schrieb Frank Wang: > On 2016/6/15 17:04, Heiko Stübner wrote: > > Am Mittwoch, 15. Juni 2016, 11:23:26 schrieb Frank Wang: > >> On 2016/6/14 21:27, Heiko Stübner wrote: > >>> Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: > The newer

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-15 Thread Guenter Roeck
On Tue, Jun 14, 2016 at 6:14 PM, Frank Wang wrote: > Hi Heiko & Guenter, > > > On 2016/6/14 22:00, Heiko Stübner wrote: >> >> Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck: >>> >>> On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote:

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-15 Thread Frank Wang
Hi Heiko, On 2016/6/15 17:04, Heiko Stübner wrote: Hi Frank, Am Mittwoch, 15. Juni 2016, 11:23:26 schrieb Frank Wang: On 2016/6/14 21:27, Heiko Stübner wrote: Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-15 Thread Heiko Stübner
Hi Frank, Am Mittwoch, 15. Juni 2016, 11:23:26 schrieb Frank Wang: > On 2016/6/14 21:27, Heiko Stübner wrote: > > Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: > >> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > >> than rk3288 and before, and most of phy-related

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Frank Wang
Hi Heiko, On 2016/6/14 21:27, Heiko Stübner wrote: Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Frank Wang
Hi Heiko & Guenter, On 2016/6/14 22:00, Heiko Stübner wrote: Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck: On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote: Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: The newer SoCs (rk3366, rk3399) take a

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Heiko Stübner
Am Dienstag, 14. Juni 2016, 07:52:13 schrieb Guenter Roeck: > On 06/12/2016 07:10 PM, Frank Wang wrote: > > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > > than rk3288 and before, and most of phy-related registers are also > > different from the past, so a new phy driver is

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Guenter Roeck
On 06/12/2016 07:10 PM, Frank Wang wrote: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required necessarily. Signed-off-by: Frank Wang

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Heiko Stübner
Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck: > On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote: > > Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: > >> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > >> than rk3288 and before, and

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Guenter Roeck
On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote: > Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: >> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block >> than rk3288 and before, and most of phy-related registers are also >> different from the past, so

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Heiko Stübner
Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > than rk3288 and before, and most of phy-related registers are also > different from the past, so a new phy driver is required necessarily. > > Signed-off-by: Frank Wang

[PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-12 Thread Frank Wang
The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required necessarily. Signed-off-by: Frank Wang --- Changes in v5: - Added 'reg' in