Re: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-19 Thread Hans de Goede 

Hi,

On 15-07-15 14:35, Kishon Vijay Abraham I wrote:

Hi,

On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote:

sun4i_usb_phy_set_squelch_detect is used by other code, which may be built
as a module, so it should be exported.

Signed-off-by: Hans de Goede hdego...@redhat.com
---
Changes in v6:
-New patch in v6 of the sunxi musb support series
---
  drivers/phy/phy-sun4i-usb.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
index e17c539..b82aa26 100644
--- a/drivers/phy/phy-sun4i-usb.c
+++ b/drivers/phy/phy-sun4i-usb.c
@@ -212,6 +212,7 @@ void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, 
bool enabled)

sun4i_usb_phy_write(phy, PHY_SQUELCH_DETECT, enabled ? 0 : 2, 2);
  }
+EXPORT_SYMBOL(sun4i_usb_phy_set_squelch_detect);


EXPORT_SYMBOL_GPL?


Both work for me, feel free to fix this up if you prefer _GPL.

Regards,

Hans
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-15 Thread Kishon Vijay Abraham I 
Hi,

On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote:
 sun4i_usb_phy_set_squelch_detect is used by other code, which may be built
 as a module, so it should be exported.
 
 Signed-off-by: Hans de Goede hdego...@redhat.com

merged this patch to linux-phy tree.

Cheers
Kishon
 ---
 Changes in v6:
 -New patch in v6 of the sunxi musb support series
 ---
  drivers/phy/phy-sun4i-usb.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
 index e17c539..b82aa26 100644
 --- a/drivers/phy/phy-sun4i-usb.c
 +++ b/drivers/phy/phy-sun4i-usb.c
 @@ -212,6 +212,7 @@ void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, 
 bool enabled)
  
   sun4i_usb_phy_write(phy, PHY_SQUELCH_DETECT, enabled ? 0 : 2, 2);
  }
 +EXPORT_SYMBOL(sun4i_usb_phy_set_squelch_detect);
  
  static struct phy_ops sun4i_usb_phy_ops = {
   .init   = sun4i_usb_phy_init,
 
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-15 Thread Kishon Vijay Abraham I 
Hi,

On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote:
 sun4i_usb_phy_set_squelch_detect is used by other code, which may be built
 as a module, so it should be exported.
 
 Signed-off-by: Hans de Goede hdego...@redhat.com
 ---
 Changes in v6:
 -New patch in v6 of the sunxi musb support series
 ---
  drivers/phy/phy-sun4i-usb.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
 index e17c539..b82aa26 100644
 --- a/drivers/phy/phy-sun4i-usb.c
 +++ b/drivers/phy/phy-sun4i-usb.c
 @@ -212,6 +212,7 @@ void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, 
 bool enabled)
  
   sun4i_usb_phy_write(phy, PHY_SQUELCH_DETECT, enabled ? 0 : 2, 2);
  }
 +EXPORT_SYMBOL(sun4i_usb_phy_set_squelch_detect);

EXPORT_SYMBOL_GPL?

Thanks
Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-08 Thread Hans de Goede 
sun4i_usb_phy_set_squelch_detect is used by other code, which may be built
as a module, so it should be exported.

Signed-off-by: Hans de Goede hdego...@redhat.com
---
Changes in v6:
-New patch in v6 of the sunxi musb support series
---
 drivers/phy/phy-sun4i-usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
index e17c539..b82aa26 100644
--- a/drivers/phy/phy-sun4i-usb.c
+++ b/drivers/phy/phy-sun4i-usb.c
@@ -212,6 +212,7 @@ void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, 
bool enabled)
 
sun4i_usb_phy_write(phy, PHY_SQUELCH_DETECT, enabled ? 0 : 2, 2);
 }
+EXPORT_SYMBOL(sun4i_usb_phy_set_squelch_detect);
 
 static struct phy_ops sun4i_usb_phy_ops = {
.init   = sun4i_usb_phy_init,
-- 
2.4.3

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html