Re: [PATCH v7 2/4] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-07-22 Thread Peter Berger
On Wed, 2015-07-15 at 11:21 +0200, Johan Hovold wrote: Hi Johan: Thanks for another thoughtful and helpful review. I think I have addressed all the issues you noted and have a v8 patchset just about ready to submit. First I'll respond to each of the specific points here and in your other v7

Re: [PATCH v7 2/4] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-07-15 Thread Johan Hovold
On Sun, Jun 28, 2015 at 01:28:19PM -0500, Peter E. Berger wrote: From: Peter E. Berger pber...@brimson.com The io_ti driver fails to download firmware to Edgeport devices such as the EP/416, even when the on-disk firmware image (/lib/firmware/edgeport/down3.bin) is more current than the

[PATCH v7 2/4] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-06-28 Thread Peter E. Berger
From: Peter E. Berger pber...@brimson.com The io_ti driver fails to download firmware to Edgeport devices such as the EP/416, even when the on-disk firmware image (/lib/firmware/edgeport/down3.bin) is more current than the version on the EP/416. The current download code is broken in a few ways.