Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-20 Thread Kishon Vijay Abraham I
Arnd, On Wednesday 15 April 2015 03:17 AM, Arnd Bergmann wrote: On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote: [1] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111 Kishon,removing select GENERIC_PHY also breaks

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-15 Thread Alan Stern
On Wed, 15 Apr 2015, rajeev kumar wrote: @@ -88,15 +88,13 @@ static int ehci_platform_power_on(struct platform_device *dev) } for (phy_num = 0; phy_num priv-num_phys; phy_num++) { - if (priv-phys[phy_num]) { - ret =

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-15 Thread rajeev kumar
On Wed, Apr 15, 2015 at 8:06 PM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 15 Apr 2015, rajeev kumar wrote: @@ -88,15 +88,13 @@ static int ehci_platform_power_on(struct platform_device *dev) } for (phy_num = 0; phy_num priv-num_phys; phy_num++) { -

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-15 Thread rajeev kumar
On Tue, Apr 14, 2015 at 3:40 AM, Arun Ramamurthy arun.ramamur...@broadcom.com wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Arnd Bergmann
On Tuesday 14 April 2015 13:19:34 Greg Kroah-Hartman wrote: On Mon, Apr 13, 2015 at 03:10:46PM -0700, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Greg Kroah-Hartman
On Mon, Apr 13, 2015 at 03:10:46PM -0700, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Greg Kroah-Hartman
On Tue, Apr 14, 2015 at 03:17:30PM +0200, Arnd Bergmann wrote: On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Arun Ramamurthy
On 15-04-14 07:21 AM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 14 April 2015 06:57 PM, Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 03:17:30PM +0200, Arnd Bergmann wrote: On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Arun Ramamurthy
My apologies Alan, I missed that comment I was indeed trying to avoid the 80 column rule. It looks like i will have to resend this patch, so i will reformat the code then. Thanks On 15-04-14 07:41 AM, Alan Stern wrote: On Mon, 13 Apr 2015, Arun Ramamurthy wrote: Getting phys by index

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Alan Stern
On Mon, 13 Apr 2015, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Kishon Vijay Abraham I
Hi Arnd, On Tuesday 14 April 2015 06:47 PM, Arnd Bergmann wrote: On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed,

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Kishon Vijay Abraham I
Hi, On Tuesday 14 April 2015 06:57 PM, Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 03:17:30PM +0200, Arnd Bergmann wrote: On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Arnd Bergmann
On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote: [1] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111 Kishon,removing select GENERIC_PHY also breaks the builds for certain architectures (i386 and x84_64). Is

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Arnd Bergmann
On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed, we should probably apply the same solution to all current users

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-14 Thread Greg Kroah-Hartman
On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: On Tuesday 14 April 2015 13:19:34 Greg Kroah-Hartman wrote: On Mon, Apr 13, 2015 at 03:10:46PM -0700, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when

[PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-13 Thread Arun Ramamurthy
Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com ---