Re: [RFC][PATCH] usbnet: Fix tx_bytes statistic running backward in cdc_ncm

2015-02-27 Thread Bjørn Mork
Ben Hutchings ben.hutchi...@codethink.co.uk writes: cdc_ncm disagrees with usbnet about how much framing overhead should be counted in the tx_bytes statistics, and tries 'fix' this by decrementing tx_bytes on the transmit path. But statistics must never be decremented except due to

Re: [RFC][PATCH] usbnet: Fix tx_bytes statistic running backward in cdc_ncm

2015-02-27 Thread Oliver Neukum
On Fri, 2015-02-27 at 10:12 +0100, Bjørn Mork wrote: Ben Hutchings ben.hutchi...@codethink.co.uk writes: cdc_ncm disagrees with usbnet about how much framing overhead should be counted in the tx_bytes statistics, and tries 'fix' this by decrementing tx_bytes on the transmit path. But

[RFC][PATCH] usbnet: Fix tx_bytes statistic running backward in cdc_ncm

2015-02-26 Thread Ben Hutchings
cdc_ncm disagrees with usbnet about how much framing overhead should be counted in the tx_bytes statistics, and tries 'fix' this by decrementing tx_bytes on the transmit path. But statistics must never be decremented except due to roll-over; this will thoroughly confuse user-space. Also,