Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-16 Thread Julius Werner
> To handle things smarter, I think I need to research how to deal with > hubs attached to hubs attached to hubs. For instance: > > dwc2 > -> multi_tt hub > -> single_tt hub > -> device 1 > -> device 2 Keep in mind that there's always at most one (active) TT between host and

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-16 Thread Doug Anderson
John, On Wed, Nov 11, 2015 at 8:29 PM, John Youn wrote: > On 11/11/2015 4:22 PM, Doug Anderson wrote: >> John, >> >> On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote: >>> hi John , >>> >>> As we talked yesterday, I tried to fix the split schedule

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-14 Thread Alan Stern
On Fri, 13 Nov 2015, Doug Anderson wrote: > To handle things smarter, I think I need to research how to deal with > hubs attached to hubs attached to hubs. For instance: > > dwc2 > -> multi_tt hub > -> single_tt hub > -> device 1 > -> device 2 > -> single_tt hub >

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-13 Thread Doug Anderson
John, On Thu, Nov 12, 2015 at 9:05 PM, John Youn wrote: > It seems to be an issue with single TT hubs. I've tried several > multi-TT hubs with no issues. Agreed. > With a single TT hub I do see a problem though not the exact one > described. I see corrupted and dropped

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-12 Thread Yunzhi Li
Hi John 在 2015/11/12 12:29, John Youn 写道: On 11/11/2015 4:22 PM, Doug Anderson wrote: John, On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote: hi John , As we talked yesterday, I tried to fix the split schedule sequence. This patch will avoid scheduling SSPLIT-IN

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-12 Thread John Youn
On 11/11/2015 8:46 PM, Doug Anderson wrote: > John, > > On Wed, Nov 11, 2015 at 8:29 PM, John Youn wrote: >> I also feel it is not quite right as the SSPLIT should be able to >> happen during the SSPLIT of another device. I tried to reproduce >> and see the same

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-11 Thread John Youn
On 11/11/2015 4:22 PM, Doug Anderson wrote: > John, > > On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote: >> hi John , >> >> As we talked yesterday, I tried to fix the split schedule sequence. This >> patch will >> avoid scheduling SSPLIT-IN packet for another device

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-11 Thread Doug Anderson
John, On Wed, Nov 11, 2015 at 8:29 PM, John Youn wrote: > I also feel it is not quite right as the SSPLIT should be able to > happen during the SSPLIT of another device. I tried to reproduce > and see the same scheduling but don't see any hang due to it. > > Yunzhi, any

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-11 Thread Doug Anderson
John, On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote: > hi John , > > As we talked yesterday, I tried to fix the split schedule sequence. This > patch will > avoid scheduling SSPLIT-IN packet for another device between > SSPLIT-OUT-begin and > SSPLIT-OUT-end, now the

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-09 Thread Doug Anderson
Hi, On Mon, Nov 9, 2015 at 1:57 AM, Yunzhi Li wrote: > It seems that we are debugging two different issues, your new patch which > rewrite > the microframe scheduler doesn't resolve my problem. My patch fix chrome-os > issue > #46547 not related to the particular Microsoft

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-09 Thread Yunzhi Li
hi Doug 在 2015/11/7 7:56, Doug Anderson 写道: lyz@, On Fri, Nov 6, 2015 at 1:36 AM, Yunzhi Li wrote: Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN packet between SSPLIT-begin and SSPLIT-end. Signed-off-by: Yunzhi Li ---

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-06 Thread Doug Anderson
lyz@, On Fri, Nov 6, 2015 at 1:36 AM, Yunzhi Li wrote: > Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN > packet between SSPLIT-begin and SSPLIT-end. > > Signed-off-by: Yunzhi Li > --- > drivers/usb/dwc2/hcd.c | 4 > 1 file

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-06 Thread Yunzhi Li
hi John , As we talked yesterday, I tried to fix the split schedule sequence. This patch will avoid scheduling SSPLIT-IN packet for another device between SSPLIT-OUT-begin and SSPLIT-OUT-end, now the keyboard and Jebra audio speaker could work together well, but I'm not sure if this is

[RFC] usb: dwc2: hcd: fix split schedule issue

2015-11-06 Thread Yunzhi Li
Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN packet between SSPLIT-begin and SSPLIT-end. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/hcd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index