Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-08 Thread Bjørn Mork
Hayes Wang writes: > Bjørn Mork [mailto:bj...@mork.no] >> Sent: Thursday, September 08, 2016 3:55 PM > [...] >> Yes, I see that. But is that strictly necessary? Couldn't you just say: >> "CDC ECM is supported by cdc_ether and therefore limited to the features >>

Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-08 Thread Oliver Neukum
On Thu, 2016-09-08 at 13:02 +, Hayes Wang wrote: > I tested above method before. And I found that the cdc_ether > was loaded before switching the configuration. The behavior > of loading one driver and changing to another driver has > opportunity to let our some previous chips become

RE: [PATCH net-next 0/3] r8152: configuration setting

2016-09-08 Thread Hayes Wang
Bjørn Mork [mailto:bj...@mork.no] > Sent: Thursday, September 08, 2016 3:55 PM [...] > Yes, I see that. But is that strictly necessary? Couldn't you just say: > "CDC ECM is supported by cdc_ether and therefore limited to the features > implemented by cdc_ether. If you want feature X, then please

Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-08 Thread Bjørn Mork
Hayes Wang writes: > Bjørn Mork [mailto:bj...@mork.no] >> Sent: Wednesday, September 07, 2016 9:51 PM > [...] >> So this adds a lot of code to work around the issues you introduced by >> unnecessarily blacklisting the CDC ECM configuration earlier, and still >> makes the

RE: [PATCH net-next 0/3] r8152: configuration setting

2016-09-07 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Thursday, September 08, 2016 8:38 AM [...] > By forcing a certain mode via a Kconfig value, you are basically making it > impossible for distributions to do something reasonable here. The request is always from some manufacturers, not end users.

RE: [PATCH net-next 0/3] r8152: configuration setting

2016-09-07 Thread Hayes Wang
Bjørn Mork [mailto:bj...@mork.no] > Sent: Wednesday, September 07, 2016 9:51 PM [...] > So this adds a lot of code to work around the issues you introduced by > unnecessarily blacklisting the CDC ECM configuration earlier, and still > makes the r8152 driver handle the device even in ECM mode. I

Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-07 Thread David Miller
From: Hayes Wang Date: Wed, 7 Sep 2016 16:12:19 +0800 > Some people prefer to use ECM mode rather than vendor mode. Therefore, I add > CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB > configuration value which they want. The default is to

Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-07 Thread Bjørn Mork
[ CCing Oliver, who AFAIK still is the cdc_ether maintainer and should have the final word on this ] Hayes Wang writes: > Some people prefer to use ECM mode rather than vendor mode. Therefore, I add > CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose