Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> > I can't send an incremental patch for this, I need to ask: did you try > > SMBUS_QUICK with it? > Tried it today using i2cdetect and it looks good to me. Yup, looks good. Thanks for checking! signature.asc Description: PGP signature

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > @@ -140,5 +140,6 @@ obj-$(CONFIG_I2C_SIBYTE)+= i2c-sibyte.o > > obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o > > obj-$(CONFIG_SCx200_ACB) += scx200_acb.o > > obj-$(CONFIG_I2C_FSI) += i2c-fsi.o > > +obj-$(CONFIG_I2C_NVIDIA_GPU) +=

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > It will be good if both of them can go together either through I2C or > > USB subsystem. Since USB part is reviewed and has Acked-by Heikki so > > please take that also. > > Hmmm, technicallly, there is no need to let them go together. There is no > strict dependency. Agree. >

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> It will be good if both of them can go together either through I2C or > USB subsystem. Since USB part is reviewed and has Acked-by Heikki so please > take that also. Hmmm, technicallly, there is no need to let them go together. There is no strict dependency. Yet, since Heikki gave his ack, I

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C > > controller which can be accessed over I2C. > > > > This driver adds I2C bus driver to communicate with Type-C controller. > > I2C client driver will be part of USB Type-C UCSI driver. > > > > Signed-off-by: Ajay

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> @@ -140,5 +140,6 @@ obj-$(CONFIG_I2C_SIBYTE) += i2c-sibyte.o > obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o > obj-$(CONFIG_SCx200_ACB) += scx200_acb.o > obj-$(CONFIG_I2C_FSI)+= i2c-fsi.o > +obj-$(CONFIG_I2C_NVIDIA_GPU) += i2c-nvidia-gpu.o Oh, I fixed this up

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
On Fri, Oct 26, 2018 at 09:36:58AM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU card has USB Type-C interface. There is a > Type-C controller which can be accessed over I2C. > > This driver adds I2C bus driver to communicate with Type-C controller. > I2C client driver will be part of USB Type-C