Re: [linux-usb-devel] Usb hangs during small and large file transfer

2006-06-02 Thread Pete Zaitcev
On Fri, 2 Jun 2006 15:25:39 -0700, "Vivek Dharmadhikari" <[EMAIL PROTECTED]> wrote: > >The '1t' pseudo file provides the counters, if anyone is interested > > What are these counters ? > How different are these counters from the current format of usbmon log ? > Do the file usbmon.txt contains i

Re: [linux-usb-devel] [patch 4/4] usb: drivers/usb/core/devio.c dereferences a userspace pointer

2006-06-02 Thread Greg KH
On Fri, Jun 02, 2006 at 04:21:44PM -0700, Andrew Morton wrote: > > Either way it's still a userspace pointer (the data itself didn't change > > in the copy_from_user), and we are using that data to pass to that > > function. > > Yes, it's a userspace pointer. But in the present code, we're readin

Re: [linux-usb-devel] [patch 4/4] usb: drivers/usb/core/devio.c dereferences a userspace pointer

2006-06-02 Thread Andrew Morton
Greg KH <[EMAIL PROTECTED]> wrote: > > On Fri, Jun 02, 2006 at 03:46:52PM -0700, Andrew Morton wrote: > > Greg KH <[EMAIL PROTECTED]> wrote: > > > > > > On Thu, Jun 01, 2006 at 08:48:46PM -0700, [EMAIL PROTECTED] wrote: > > > > > > > > From: Philippe Retornaz <[EMAIL PROTECTED]> > > > > > > > > S

Re: [linux-usb-devel] Usb hangs during small and large file transfer

2006-06-02 Thread Vivek Dharmadhikari
Alan >The problem is more likely to be in your device than in the kernel. You are proabably right here. I used Catalyst USB analyzer to cross check the results of usbmon log. USB analyzer indicated many hot spots of 30 seconds and 6 seconds which are in aggrement with usbmon log. >The 30-seco

Re: [linux-usb-devel] [patch 4/4] usb: drivers/usb/core/devio.c dereferences a userspace pointer

2006-06-02 Thread Greg KH
On Fri, Jun 02, 2006 at 03:46:52PM -0700, Andrew Morton wrote: > Greg KH <[EMAIL PROTECTED]> wrote: > > > > On Thu, Jun 01, 2006 at 08:48:46PM -0700, [EMAIL PROTECTED] wrote: > > > > > > From: Philippe Retornaz <[EMAIL PROTECTED]> > > > > > > See http://bugzilla.kernel.org/show_bug.cgi?id=6617. >

Re: [linux-usb-devel] Usb hangs during small and large file transfer

2006-06-02 Thread Alan Stern
On Fri, 2 Jun 2006, Vivek Dharmadhikari wrote: > Alan > > >Apparently you are using an old kernel version. With more recent versions > >(like 2.6.17-rc5), usbmon provides a lot more information. > > I am using 2.6.12 kernel. > > >Also it looks like either usbmon has dropped a lot of lines or

Re: [linux-usb-devel] [PATCH RFC 0/11] usbserial: Serial Core port.

2006-06-02 Thread Pete Zaitcev
On Fri, 02 Jun 2006 11:03:29 +0100, David Woodhouse <[EMAIL PROTECTED]> wrote: > On Thu, 2006-06-01 at 23:48 -0700, Pete Zaitcev wrote: > > > > > The tests I've done so far weren't anything serious: as the mobile > > > supports a > > > AT command set, I have used the ones (with minicom) which tr

Re: [linux-usb-devel] [PATCH 8/11] usbserial: pl2303: Ports tty functions.

2006-06-02 Thread Greg KH
On Fri, Jun 02, 2006 at 03:41:21PM -0700, Pete Zaitcev wrote: > On Fri, 2 Jun 2006 13:50:14 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > > On Fri, Jun 02, 2006 at 12:03:14AM -0300, Luiz Fernando N.Capitulino wrote: > > > > 2. The new pl2303's set_termios() can (still) sleep. Serial Core's > > >

Re: [linux-usb-devel] [patch 4/4] usb: drivers/usb/core/devio.c dereferences a userspace pointer

2006-06-02 Thread Andrew Morton
Greg KH <[EMAIL PROTECTED]> wrote: > > On Thu, Jun 01, 2006 at 08:48:46PM -0700, [EMAIL PROTECTED] wrote: > > > > From: Philippe Retornaz <[EMAIL PROTECTED]> > > > > See http://bugzilla.kernel.org/show_bug.cgi?id=6617. > > > > This function dereference a __user pointer. > > > > (akpm: this code

Re: [linux-usb-devel] [PATCH 8/11] usbserial: pl2303: Ports tty functions.

2006-06-02 Thread Pete Zaitcev
On Fri, 2 Jun 2006 13:50:14 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Jun 02, 2006 at 12:03:14AM -0300, Luiz Fernando N.Capitulino wrote: > > 2. The new pl2303's set_termios() can (still) sleep. Serial Core's > > documentation says that that method must not sleep, but I couldn't f

Re: [linux-usb-devel] [patch 4/4] usb: drivers/usb/core/devio.c dereferences a userspace pointer

2006-06-02 Thread Greg KH
On Thu, Jun 01, 2006 at 08:48:46PM -0700, [EMAIL PROTECTED] wrote: > > From: Philippe Retornaz <[EMAIL PROTECTED]> > > See http://bugzilla.kernel.org/show_bug.cgi?id=6617. > > This function dereference a __user pointer. > > (akpm: this code is deeply fishy. Are the types correct?) > > Signed-

Re: [linux-usb-devel] [PATCH] new devices for the Option driver

2006-06-02 Thread Greg KH
On Sat, Jun 03, 2006 at 12:09:34AM +0200, Matthias Urlichs wrote: > Hi, > > Greg KH: > > > > Why create a new option? What does this do? You aren't using it in the > > build anywhere. > > > It turns on both OHCI and PCCARD support. Conceivably I could turn that > around and put it somewhere in

Re: [linux-usb-devel] Usb hangs during small and large file transfer

2006-06-02 Thread Vivek Dharmadhikari
Pete >The '1t' pseudo file provides the counters, if anyone is interested What are these counters ? How different are these counters from the current format of usbmon log ? Do the file usbmon.txt contains information regarding these counters ? Regards Vivek -Original Message- From: Pet

Re: [linux-usb-devel] Usb hangs during small and large file transfer

2006-06-02 Thread Vivek Dharmadhikari
Alan >Apparently you are using an old kernel version. With more recent versions >(like 2.6.17-rc5), usbmon provides a lot more information. I am using 2.6.12 kernel. >Also it looks like either usbmon has dropped a lot of lines or you have >edited them out of the log. I pasted few lines from

Re: [linux-usb-devel] [PATCH] new devices for the Option driver

2006-06-02 Thread Matthias Urlichs
Hi, Greg KH: > > Why create a new option? What does this do? You aren't using it in the > build anywhere. > It turns on both OHCI and PCCARD support. Conceivably I could turn that around and put it somewhere in the pcmcia section; the problem is that there's no obvious place to do that, as the

[linux-usb-devel] patch usb-hub-use-usb_reset_composite_device.patch added to gregkh-2.6 tree

2006-06-02 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: USB hub: use usb_reset_composite_device to my gregkh-2.6 tree. Its filename is usb-hub-use-usb_reset_composite_device.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/greg

Re: [linux-usb-devel] [PATCH] new devices for the Option driver

2006-06-02 Thread Greg KH
On Fri, Jun 02, 2006 at 11:48:56AM +0200, Matthias Urlichs wrote: > This patch extends the "option" driver with a few more devices, > some of which are actually connected to USB the "right" way -- > as opposed to doing it via PCMCIA and OHCI. > > Signed-Off-By: Matthias Urlichs <[EMAIL PROTECTED]>

Re: [linux-usb-devel] [PATCH 8/11] usbserial: pl2303: Ports tty functions.

2006-06-02 Thread Greg KH
On Fri, Jun 02, 2006 at 12:03:14AM -0300, Luiz Fernando N.Capitulino wrote: > 2. The new pl2303's set_termios() can (still) sleep. Serial Core's > documentation says that that method must not sleep, but I couldn't find > where in the Serial Core code it's called in atomic context. So, i

Re: [linux-usb-devel] [PATCH RFC 0/11] usbserial: Serial Core port.

2006-06-02 Thread Greg KH
On Fri, Jun 02, 2006 at 12:03:06AM -0300, Luiz Fernando N.Capitulino wrote: > > Hi folks. > > This patch series is my first attempt to port the USB-Serial layer to the > Serial Core API. Currently USB-Serial uses the TTY layer directly, duplicating > code and solutions from the Serial Core impl

Re: [linux-usb-devel] USB devices fail unnecessarily on unpowered hubs

2006-06-02 Thread David Liontooth
Alan Stern wrote: > Trying to draw too much current from an unpowered hub can and does cause > data loss. > I consider this issue closed; thank you for looking at it. The workaround is reasonably simple for the common situation of mounting a USB stick on a keyboard, perhaps with a mouse attache

Re: [linux-usb-devel] Usb hangs during small and large file transfer

2006-06-02 Thread Pete Zaitcev
On Fri, 2 Jun 2006 11:39:05 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > Also it looks like either usbmon has dropped a lot of lines or you have > edited them out of the log. The '1t' pseudo file provides the counters, if anyone is interested. Most of the time, the main reason for dropp

Re: [linux-usb-devel] revert-gregkh-usb-usb-ohci-avoids-root-hub-timer-polling.patch

2006-06-02 Thread David Brownell
On Friday 02 June 2006 9:04 am, Greg KH wrote: > On Thu, Jun 01, 2006 at 09:19:26PM -0700, David Brownell wrote: > > On Thursday 01 June 2006 8:46 pm, Andrew Morton wrote: > > > > > > fyi, I continue to revert this patch from Greg's tree. > > > > Here's a somewhat better version, FYI. Still has

Re: [linux-usb-devel] revert-gregkh-usb-usb-ohci-avoids-root-hub-timer-polling.patch

2006-06-02 Thread Greg KH
On Thu, Jun 01, 2006 at 09:19:26PM -0700, David Brownell wrote: > On Thursday 01 June 2006 8:46 pm, Andrew Morton wrote: > > > > fyi, I continue to revert this patch from Greg's tree. > > Here's a somewhat better version, FYI. Still has some issues, > but seemingly nothing quite as nasty as Rafa

Re: [linux-usb-devel] Problems using USB repeater

2006-06-02 Thread Alan Stern
On Fri, 2 Jun 2006, Rainer Becker wrote: > I have difficulties with an USB repeater cable. It uses an USB hub as > repeater. > Here are the error messages: > > Jun 2 17:12:26 kwasir kernel: hub 5-2.4:1.0: Cannot enable port 1. Maybe the > USB cable is bad? > Jun 2 17:12:27 kwasir kernel: hub

Re: [linux-usb-devel] Usb hangs during small and large file transfer

2006-06-02 Thread Alan Stern
On Thu, 1 Jun 2006, Vivek Dharmadhikari wrote: > Alan > > I used usbmon to gain more visibility and i see some interesting points > in it. I am reproducing a small and relevent portion of usbmon log > below. Note that the test comprises of writing about 12Mbytes of data to > 2.0 external USB hard

Re: [linux-usb-devel] Problem in HCD resume

2006-06-02 Thread Alan Stern
On Fri, 2 Jun 2006 [EMAIL PROTECTED] wrote: > Hi, > I was trying suspend/resume of OHCI based host controller. I > suspend the device interface, device/port and the roothub interface/bus > selectively through sysfs. > According to Power Management sub-system if I resume the roothub > interfa

[linux-usb-devel] Problems using USB repeater

2006-06-02 Thread Rainer Becker
I have difficulties with an USB repeater cable. It uses an USB hub as repeater. Here are the error messages: Jun 2 17:12:26 kwasir kernel: hub 5-2.4:1.0: Cannot enable port 1. Maybe the USB cable is bad? Jun 2 17:12:27 kwasir kernel: hub 5-2.4:1.0: Cannot enable port 1. Maybe the USB cable is

Re: [linux-usb-devel] USB devices fail unnecessarily on unpowered hubs

2006-06-02 Thread Alan Stern
On Thu, 1 Jun 2006, David Liontooth wrote: > What are the reasons not to do this? What happens if a USB stick is > underpowered to one unit? Nothing? Slower transmission? Data loss? Flash > memory destruction? If it's just speed, it's a price well worth paying. I do wish people would read the ear

Re: [linux-usb-devel] [PATCH RFC 0/11] usbserial: Serial Core port.

2006-06-02 Thread Luiz Fernando N. Capitulino
On Fri, 02 Jun 2006 14:54:06 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: | On Fri, 2006-06-02 at 10:45 -0300, Luiz Fernando N. Capitulino wrote: | > Unfortunally my cables only connects devices to the computers | > (ie, I can't connect two computers). | > | > Don't know if exists a Prolifi

Re: [linux-usb-devel] [PATCH RFC 0/11] usbserial: Serial Core port.

2006-06-02 Thread David Woodhouse
On Fri, 2006-06-02 at 10:45 -0300, Luiz Fernando N. Capitulino wrote: > Unfortunally my cables only connects devices to the computers > (ie, I can't connect two computers). > > Don't know if exists a Prolific USB <-> DB9, but if it does, would > be good if someone could make the test. Seems easy

Re: [linux-usb-devel] [PATCH RFC 0/11] usbserial: Serial Core port.

2006-06-02 Thread Luiz Fernando N. Capitulino
On Fri, 02 Jun 2006 11:03:29 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: | On Thu, 2006-06-01 at 23:48 -0700, Pete Zaitcev wrote: | > | > > The tests I've done so far weren't anything serious: as the mobile supports a | > > AT command set, I have used the ones (with minicom) which transfer

Re: [linux-usb-devel] [PATCH RFC 0/11] usbserial: Serial Core port.

2006-06-02 Thread Luiz Fernando N. Capitulino
Hi Pete, On Thu, 1 Jun 2006 23:48:33 -0700 Pete Zaitcev <[EMAIL PROTECTED]> wrote: | On Fri, 02 Jun 2006 00:03:06 -0300, "Luiz Fernando N.Capitulino" <[EMAIL PROTECTED]> wrote: | | This looks interesting, although I do not know if it buys us much. Yeah, it will be a lot of work to port all

Re: [linux-usb-devel] [PATCH] ipaq.c bugfixes

2006-06-02 Thread Frank Gevaerts
On Fri, Jun 02, 2006 at 09:59:35AM -0300, Luiz Fernando N. Capitulino wrote: > On Thu, 1 Jun 2006 21:16:54 +0200 > Frank Gevaerts <[EMAIL PROTECTED]> wrote: > > | When I changed te ipaq_open code to only submit the read urb after the > | control message succeeds, these disappear. > | > | Whenever

Re: [linux-usb-devel] [PATCH] ipaq.c bugfixes

2006-06-02 Thread Luiz Fernando N. Capitulino
On Thu, 1 Jun 2006 21:16:54 +0200 Frank Gevaerts <[EMAIL PROTECTED]> wrote: | When I changed te ipaq_open code to only submit the read urb after the | control message succeeds, these disappear. | | Whenever the usb_control_msg returns with ETIMEDOUT (-110), in both code | variants, when the devic

[linux-usb-devel] Problem in HCD resume

2006-06-02 Thread rasmit.ranjan
Hi, I was trying suspend/resume of OHCI based host controller. I suspend the device interface, device/port and the roothub interface/bus selectively through sysfs. According to Power Management sub-system if I resume the roothub interface the all the downsteam devices( device/port and devic

Re: [linux-usb-devel] revert-gregkh-usb-usb-ohci-avoids-root-hub-timer-polling.patch

2006-06-02 Thread Rafael J. Wysocki
On Friday 02 June 2006 06:19, David Brownell wrote: > On Thursday 01 June 2006 8:46 pm, Andrew Morton wrote: > > > > fyi, I continue to revert this patch from Greg's tree. > > Here's a somewhat better version, FYI. Still has some issues, > but seemingly nothing quite as nasty as Rafael reported.

Re: [linux-usb-devel] [PATCH RFC 0/11] usbserial: Serial Core port.

2006-06-02 Thread David Woodhouse
On Thu, 2006-06-01 at 23:48 -0700, Pete Zaitcev wrote: > > > The tests I've done so far weren't anything serious: as the mobile > > supports a > > AT command set, I have used the ones (with minicom) which transfers more > > data. > > Of course that I also did module load/unload tests, tried to

[linux-usb-devel] [PATCH] new devices for the Option driver

2006-06-02 Thread Matthias Urlichs
This patch extends the "option" driver with a few more devices, some of which are actually connected to USB the "right" way -- as opposed to doing it via PCMCIA and OHCI. Signed-Off-By: Matthias Urlichs <[EMAIL PROTECTED]> --- --- a/drivers/usb/serial/Kconfig2006-06-02 11:45:27.701919000

Re: [linux-usb-devel] [patch 1/4] Fix SCO on some bluetooth adapters

2006-06-02 Thread Olivier Galibert
On Fri, Jun 02, 2006 at 08:52:46AM +0200, Marcel Holtmann wrote: > Hi Andrew, > > > Some bluetooth adapters return an incorrect number of sco packets in > > READ_BUFFER_SIZE. Fix it. > > please hold this one off. We might not even need it. I am playing with > changes to the SCO flow control in t

Re: [linux-usb-devel] usb-storage: This device (05ab, 0060, 1106 S 06 P 50) has unneeded SubClass and Protocol entries in unusual_devs.h

2006-06-02 Thread Phil Dibowitz
Joerg Thoennes wrote: > Jun 1 10:25:21 hostname kernel: usb 2-4: new high speed USB device > using address 2 > Jun 1 10:25:22 hostname kernel: Initializing USB Mass Storage driver... > Jun 1 10:25:22 hostname kernel: usb-storage: This device > (05ab,0060,1106 S 06 P 50) has unneeded SubClass and

Re: [linux-usb-devel] USB devices fail unnecessarily on unpowered hubs

2006-06-02 Thread Oliver Neukum
Am Freitag, 2. Juni 2006 02:03 schrieb David Liontooth: > The MaxPower value does not appear to be a reliable index of this. My > USB stick has a MaxPower value of 178mA and works flawlessly off an > unpowered hub. Unfortunately devices don't seem to tell us what their It works flawlessly on all

Re: [linux-usb-devel] [patch 1/4] Fix SCO on some bluetooth adapters

2006-06-02 Thread Marcel Holtmann
Hi Andrew, > Some bluetooth adapters return an incorrect number of sco packets in > READ_BUFFER_SIZE. Fix it. please hold this one off. We might not even need it. I am playing with changes to the SCO flow control in the Bluetooth core. Lets see how far they work before adding another quirk. Reg

Re: [linux-usb-devel] [PATCH RFC 0/11] usbserial: Serial Core port.

2006-06-02 Thread Pete Zaitcev
On Fri, 02 Jun 2006 00:03:06 -0300, "Luiz Fernando N.Capitulino" <[EMAIL PROTECTED]> wrote: This looks interesting, although I do not know if it buys us much. The code seems sane at first view. The private lock inside pl2303 saves you from the most obvious races. > The tests I've done so far we