Re: [linux-usb-devel] [PATCH 1/1] race condition fixes for usb-serial - new attempt - for review

2007-03-26 Thread Oliver Neukum
Am Samstag, 24. März 2007 03:47 schrieb John: > +struct usb_serial *usb_serial_get_by_index_ex(unsigned index, int * > return_reserved) > { > struct usb_serial *serial; > > spin_lock(&table_lock); > serial = serial_table[index]; > > + if(return_reserved) { > +

[linux-usb-devel] usbmon status && extended urb information for binary API

2007-03-26 Thread Paolo Abeni
hello, I spend a few time in the last days using latest usbmon patch (with bus 0 interface). So far I did not notice any issue. My knowledge of the module removal process is far from complete, so I can't perform any formal correctness test for rmmod. I used a linux-2.6.21-rc4 tree with the mon_e

Re: [linux-usb-devel] Earthmate LT-20 USB GPS Functionality Broken By 2.6.19 'cypress_m8' Patch

2007-03-26 Thread Mike Isely
On Mon, 26 Mar 2007, Marr wrote: > Greetings, > > *** Please CC: me on replies -- I'm not subscribed. > > A patch by Mike Isely that went into what became kernel 2.6.19 has modified > 'cypress_m8.c' in such a way that it makes the DeLorme Earthmate LT-20 USB > GPS receiver stop working entirel

[linux-usb-devel] [patch] usb-serial, ti_usb: fix usb configuration changing

2007-03-26 Thread Oleg Verych
usb-serial, ti_usb: fix usb configuration changing Remove bogus error messages, comments with script. Use new usb-configuration interface for usb-interface drivers. Cc: Al Borchers <[EMAIL PROTECTED]> Signed-off-by: Oleg Verych --- Magic numbers and some commnets were removed. Return status

Re: [linux-usb-devel] [RFC/PATCH 0/7] Move USB input devices to drivers/input

2007-03-26 Thread Greg KH
On Tue, Mar 27, 2007 at 07:12:29AM +0200, Jiri Kosina wrote: > On Mon, 26 Mar 2007, Greg KH wrote: > > > It is fine with me for you to do this, and you can send it to Linus if > > you want to, with: > > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > added to all of these. > > Thanks

Re: [linux-usb-devel] [RFC/PATCH 0/7] Move USB input devices to drivers/input

2007-03-26 Thread Greg KH
On Tue, Mar 27, 2007 at 12:51:18AM -0400, Dmitry Torokhov wrote: > On Tuesday 27 March 2007 00:29, Greg KH wrote: > > On Tue, Mar 27, 2007 at 12:13:06AM -0400, Dmitry Torokhov wrote: > > > Hi Greg, > > > > > > As I promised several month ago here is a patch series that moves > > > all USB input de

Re: [linux-usb-devel] [RFC/PATCH 0/7] Move USB input devices to drivers/input

2007-03-26 Thread Jiri Kosina
On Mon, 26 Mar 2007, Greg KH wrote: > It is fine with me for you to do this, and you can send it to Linus if > you want to, with: > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > added to all of these. > Thanks for doing this. To complement this, I have the following patch queued i

Re: [linux-usb-devel] [RFC/PATCH 0/7] Move USB input devices to drivers/input

2007-03-26 Thread Dmitry Torokhov
On Tuesday 27 March 2007 00:29, Greg KH wrote: > On Tue, Mar 27, 2007 at 12:13:06AM -0400, Dmitry Torokhov wrote: > > Hi Greg, > > > > As I promised several month ago here is a patch series that moves > > all USB input devices, except full HID, to drivers/input. The reason > > behind the move is t

Re: [linux-usb-devel] Why i lost speed in transplant driver from 2.4 to 2.6 ?

2007-03-26 Thread Greg KH
On Tue, Mar 27, 2007 at 12:01:36PM +0800, DuRui wrote: > Hello everybody > > I have creat 3 endpiont, which one for intrrupt in, one for bulk in, > and the third for bluk out. my driver could reach the transport rate at > 20MB/s in 2.4 version kernel. but in 2.6 version i only got a

Re: [linux-usb-devel] [RFC/PATCH 0/7] Move USB input devices to drivers/input

2007-03-26 Thread Greg KH
On Tue, Mar 27, 2007 at 12:13:06AM -0400, Dmitry Torokhov wrote: > Hi Greg, > > As I promised several month ago here is a patch series that moves > all USB input devices, except full HID, to drivers/input. The reason > behind the move is that I am trying to have all input drivers in > the same pla

[linux-usb-devel] [RFC/PATCH 6/7] move USB keyboards under drivers/input/keyboard

2007-03-26 Thread Dmitry Torokhov
Input: move USB keyboards under drivers/input/keyboard This will allow concentrating all input devices in one place in {menu|x|q}config. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/usb/input/usbkbd.c | 362 drivers/input/keyboard

[linux-usb-devel] [RFC/PATCH 5/7] move USB gamepads under drivers/input/joystick

2007-03-26 Thread Dmitry Torokhov
Input: move USB gamepads under drivers/input/joystick This will allow concentrating all input devices in one place in {menu|x|q}config. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/usb/input/xpad.c| 428 drivers/input/joystick

[linux-usb-devel] [RFC/PATCH 3/7] move USB touchscreens under drivers/input/touchscreen

2007-03-26 Thread Dmitry Torokhov
Input: move USB touchscreens under drivers/input/touchscreen This will allow concentrating all input devices in one place in {menu|x|q}config. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/usb/input/usbtouchscreen.c | 838 - drivers/input/to

[linux-usb-devel] [RFC/PATCH 1/7] Input: remove old USB touchscreen drivers

2007-03-26 Thread Dmitry Torokhov
Input: remove old USB touchscreen drivers itmtoch, mtouchusb and touchkitusb have been replaced with composite usbtouchscreen driver and can be removed now. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/usb/input/itmtouch.c| 271 --- drivers/usb/inp

[linux-usb-devel] [RFC/PATCH 0/7] Move USB input devices to drivers/input

2007-03-26 Thread Dmitry Torokhov
Hi Greg, As I promised several month ago here is a patch series that moves all USB input devices, except full HID, to drivers/input. The reason behind the move is that I am trying to have all input drivers in the same place in menuconfig, xconfig, etc. I think it makes more sense to have all keybo

[linux-usb-devel] Why i lost speed in transplant driver from 2.4 to 2.6 ?

2007-03-26 Thread DuRui
Hello everybody I have creat 3 endpiont, which one for intrrupt in, one for bulk in, and the third for bluk out. my driver could reach the transport rate at 20MB/s in 2.4 version kernel. but in 2.6 version i only got a half, 10MB/s. the same mechanism been used to implement dr

Re: [linux-usb-devel] Earthmate LT-20 USB GPS Functionality Broken By 2.6.19 'cypress_m8' Patch

2007-03-26 Thread Greg KH
On Mon, Mar 26, 2007 at 07:53:24PM -0400, Marr wrote: > Also, it's not a huge issue, but when rather large changes go into a kernel > module, shouldn't the module version be incremented? The 'cypress_m8' module > stayed at "v1.09" throughout these substantial (IMHO) changes. No, version numbers

[linux-usb-devel] Earthmate LT-20 USB GPS Functionality Broken By 2.6.19 'cypress_m8' Patch

2007-03-26 Thread Marr
Greetings, *** Please CC: me on replies -- I'm not subscribed. A patch by Mike Isely that went into what became kernel 2.6.19 has modified 'cypress_m8.c' in such a way that it makes the DeLorme Earthmate LT-20 USB GPS receiver stop working entirely. After a little digging, I narrowed the probl

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Tino Keitel
On Tue, Mar 27, 2007 at 00:21:24 +0200, Tino Keitel wrote: [...] > this is the bisect result: > > $ git bisect good > 1d619f128ba911cd3e6d6ad3475f146eb92f5c27 is first bad commit > commit 1d619f128ba911cd3e6d6ad3475f146eb92f5c27 I just tested 2.6.21-rc5 with this commit reverted and the iPod wa

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Tino Keitel
On Mon, Mar 26, 2007 at 23:26:14 +0200, Tino Keitel wrote: > On Mon, Mar 26, 2007 at 17:15:53 -0400, Alan Stern wrote: > > [...] > > > The lack of messages from the iPod seems to indicate that the hub isn't > > working right. You could try plugging the iPod into a different hub or > > directly i

Re: [linux-usb-devel] [patch 1/1] pcmcia: adding support for another hardware version of novatel merlin u740

2007-03-26 Thread Andrew Morton
On Mon, 26 Mar 2007 17:08:00 +0200 Nils Neumann <[EMAIL PROTECTED]> wrote: > Adding a new PRODUCT_ID for supporting another hardware version of the > novatel > merlin u740 pcmcia card. It's tested and working fine. > > Signed-off-by: Nils Neumann <[EMAIL PROTECTED]> > > > [patch-merlin-u740-o

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Tino Keitel
On Mon, Mar 26, 2007 at 17:15:53 -0400, Alan Stern wrote: [...] > The lack of messages from the iPod seems to indicate that the hub isn't > working right. You could try plugging the iPod into a different hub or > directly into the computer. Or maybe into a different port of that hub. Uh, I thi

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Tino Keitel
On Mon, Mar 26, 2007 at 17:15:53 -0400, Alan Stern wrote: [...] > The lack of messages from the iPod seems to indicate that the hub isn't > working right. You could try plugging the iPod into a different hub or > directly into the computer. Or maybe into a different port of that hub. I already

Re: [linux-usb-devel] [PATCH] EHCI interrupt transactions failing during CPU frequency changes

2007-03-26 Thread Stuart_Hayes
Sorry for the delayed response on this... I've been working on it and other stuff at the same time. I found a couple bugs with my last patch, and have tested quite a bit on both Intel & ServerWorks systems. Here's the new patch (very similar to the previous one I sent), and responses to your que

[linux-usb-devel] [PATCH 6/6] USB: fix usb-serial/ftdi build warning

2007-03-26 Thread Greg Kroah-Hartman
From: David Brownell <[EMAIL PROTECTED]> Fix annoying build warning: drivers/usb/serial/ftdi_sio.c:890: warning: enumeration value `FT232RL' not handled in switch Also add logic to detect FT232R chips (version 6.00, usb 2.0 full speed), so that case isn't completely useless. (NOTE: FT232RL an

[linux-usb-devel] [PATCH 3/6] USB: remove duplicated device id in airprime driver

2007-03-26 Thread Greg Kroah-Hartman
From: Jon K Hellan <[EMAIL PROTECTED]> Both airprime and option now want to handle vendor ID 0x1410, device ID 0x1100. Airprime calls it 'ExpressCard34 Qualcomm 3G CDMA'. Option calls it 'Novatel Merlin XS620/S640'. Patch attached to remove it from airprime. From: Jon K Hellan <[EMAIL PROTECTED]>

[linux-usb-devel] [PATCH 5/6] USB: fix usb-serial/generic build warning

2007-03-26 Thread Greg Kroah-Hartman
From: David Brownell <[EMAIL PROTECTED]> Fix annoying build warning when CONFIG_USB_SERIAL_GENERIC is undefined. drivers/usb/serial/generic.c:24: warning: `generic_probe' declared `static' but never defined Signed-off-by: David Brownell <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[

[linux-usb-devel] [PATCH 4/6] USB: another entry for the quirk list

2007-03-26 Thread Greg Kroah-Hartman
From: Oliver Neukum <[EMAIL PROTECTED]> this scanner disconnects upon suspend. Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- drivers/usb/core/quirks.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/u

[linux-usb-devel] [PATCH 1/6] UHCI: Fix problem caused by lack of terminating QH

2007-03-26 Thread Greg Kroah-Hartman
From: Alan Stern <[EMAIL PROTECTED]> This patch (as871) fixes a problem introduced by an earlier change. It turns out that some systems really do need to have a terminating skeleton QH present whenever FSBR is on. I don't know any way to tell which systems do need it and which don't; the easiest

[linux-usb-devel] [PATCH 2/6] USB: omap_udc: workaround dma_free_coherent() bogosity

2007-03-26 Thread Greg Kroah-Hartman
From: David Brownell <[EMAIL PROTECTED]> Various fixes to omap_udc, noted with some recent testing: - Cope with some SMP-induced braindamage in ARM's dma_{alloc,free}_coherent() implementation: alloc() can be called with IRQs blocked, but since late last year that's no longer true for free

[linux-usb-devel] [GIT PATCH] USB fixes for 2.6.21-rc5

2007-03-26 Thread Greg KH
Here are some USB fixes against 2.6.21-rc5. These patches fix a number of reported problems and compiler warnings in the current tree. Yes, hte omap_udc. and uhci patches seem a bit "big" but both David and Alan ensure me that they are correct and needed for the 2.6.21 final release. All of thes

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Alan Stern
On Mon, 26 Mar 2007, Tino Keitel wrote: > > > There are no messages from the iPod because, well, nothing happens when > > > I plug it in. I tried it 3 times. > > > > I don't understand. The dmesg log you attached shows the iPod was > > detected and recognized as scsi5 (sdc). Then some time late

Re: [linux-usb-devel] Topcom 4012 voip dect phone

2007-03-26 Thread Luca Olivetti
En/na Luca Olivetti ha escrit: > En/na Luca Olivetti ha escrit: > >> Hello, >> I'd like to write a driver (or a userspace program) to interface with >> this phone: >> >> http://www.topcom.net/productfiche.php?i=432&g=17 [...] > Looking at the data, I have a slight idea of the communication prot

Re: [linux-usb-devel] [patch 1/1] pcmcia: adding support for another hardware version of novatel merlin u740

2007-03-26 Thread Greg KH
On Mon, Mar 26, 2007 at 05:08:00PM +0200, Nils Neumann wrote: > Adding a new PRODUCT_ID for supporting another hardware version of the > novatel > merlin u740 pcmcia card. It's tested and working fine. > > Signed-off-by: Nils Neumann <[EMAIL PROTECTED]> > --- ./drivers/usb/serial/option.c.orig

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Tino Keitel
On Mon, Mar 26, 2007 at 16:28:34 -0400, Alan Stern wrote: > On Mon, 26 Mar 2007, Tino Keitel wrote: > > > Attached is a dmesg output with CONFIG_USB_DEBUG and CONFIG_USB_SUSPEND > > enabled. > > > > There are no messages from the iPod because, well, nothing happens when > > I plug it in. I tried

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Alan Stern
On Mon, 26 Mar 2007, Tino Keitel wrote: > Attached is a dmesg output with CONFIG_USB_DEBUG and CONFIG_USB_SUSPEND > enabled. > > There are no messages from the iPod because, well, nothing happens when > I plug it in. I tried it 3 times. I don't understand. The dmesg log you attached shows the i

Re: [linux-usb-devel] pxa270 - USB low speed devices - Maybe the USB cable is bad?

2007-03-26 Thread Alan Stern
On Mon, 26 Mar 2007, David Brownell wrote: > On Monday 26 March 2007 2:11 am, Girish wrote: > > > pxa27x-ohci: created debug files > > pxa27x-ohci pxa27x-ohci: resetting from state 'reset', control = 0x0 > > pxa27x-ohci pxa27x-ohci: OHCI controller state > > pxa27x-ohci pxa27x-ohci: OHCI 1.0, NO

Re: [linux-usb-devel] error handling in tty_open

2007-03-26 Thread Oliver Neukum
Am Montag, 26. März 2007 20:26 schrieb John: > Hi, > No, I don't see how it can work. > > When a device is disconnected serial_open will > fail at the very beginning You are right. All failures must be handled. I'll make a new patch. > But there may be a more serious problem. > port is stored i

Re: [linux-usb-devel] pxa270 - USB low speed devices - Maybe the USB cable is bad?

2007-03-26 Thread David Brownell
On Monday 26 March 2007 2:11 am, Girish wrote: > pxa27x-ohci: created debug files > pxa27x-ohci pxa27x-ohci: resetting from state 'reset', control = 0x0 > pxa27x-ohci pxa27x-ohci: OHCI controller state > pxa27x-ohci pxa27x-ohci: OHCI 1.0, NO legacy support registers > pxa27x-ohci pxa27x-ohci: cont

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Tino Keitel
On Mon, Mar 26, 2007 at 14:12:25 -0400, Alan Stern wrote: > On Sun, 25 Mar 2007, Tino Keitel wrote: > > > > Please recompile > > > with CONFIG_USB_DEBUG > > > and without CONFIG_USB_SUSPEND > > > > With CONFIG_USB_SUSPEND disabled, the iPod works. The dmesg output is > > attached. > > In fact, b

Re: [linux-usb-devel] [PATCH]aircable cleanup

2007-03-26 Thread Manuel Naranjo
Just tried, it works all right, thanks. Signed-off-by: Naranjo Manuel Francisco <[EMAIL PROTECTED]> > Hi, > > - proper endianness macros > - scheduling in interrupt in error case > > Regards > Oliver > > Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> > ---

Re: [linux-usb-devel] error handling in tty_open

2007-03-26 Thread John
Hi, No, I don't see how it can work. When a device is disconnected serial_open will fail at the very beginning (usb_serial_get_by_index returns NULL in my patch or lock_serial fails in your earlier patch). In both cases bailout_module_put is bypassed and ++port->cleaning_up; is not executed.

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-26 Thread Alan Stern
On Sun, 25 Mar 2007, Tino Keitel wrote: > > Please recompile > > with CONFIG_USB_DEBUG > > and without CONFIG_USB_SUSPEND > > With CONFIG_USB_SUSPEND disabled, the iPod works. The dmesg output is > attached. In fact, both logs (with and without CONFIG_USB_SUSPEND) show the iPod working. Can yo

Re: [linux-usb-devel] usbtest test-14 failure: MUSBHDRC + Netchip2280

2007-03-26 Thread David Brownell
On Monday 26 March 2007 10:36 am, David Brownell wrote: > On Monday 26 March 2007 9:19 am, Alan Stern wrote: > > On Mon, 26 Mar 2007, Pandita, Vikram wrote: > > > > If the MUSBHDRC really did send an extra OUT token, then the bug is in the > > MUSBHDRC. If it really sent an IN token but the Netch

Re: [linux-usb-devel] usbtest test-14 failure: MUSBHDRC + Netchip2280

2007-03-26 Thread David Brownell
On Monday 26 March 2007 9:19 am, Alan Stern wrote: > On Mon, 26 Mar 2007, Pandita, Vikram wrote: > > If the MUSBHDRC really did send an extra OUT token, then the bug is in the > MUSBHDRC. If it really sent an IN token but the Netchip set the flag for > an OUT token, then the bug is in the Netchip

Re: [linux-usb-devel] usbtest test-14 failure: MUSBHDRC + Netchip2280

2007-03-26 Thread Alan Stern
On Mon, 26 Mar 2007, Pandita, Vikram wrote: > On usbtest 14, the IN token sent by MUSBHDRC is being STALL'ed instead > of being NAK'ed by the Netchip device. > > Interestingly, if I enable some logs on Netchip driver or Host side, the > test 14 passes. This points to some timing related issue. Is

[linux-usb-devel] [PATCH]ark3116 memory leak

2007-03-26 Thread Oliver Neukum
Hi, this driver has a memory leak in an error case. Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> - --- a/drivers/usb/serial/ark3116.c 2007-03-22 13:36:53.0 +0100 +++ b/drivers/usb/serial/ark3116.c 2007-03-26 17:14:17.0 +02

[linux-usb-devel] [patch 1/1] pcmcia: adding support for another hardware version of novatel merlin u740

2007-03-26 Thread Nils Neumann
Adding a new PRODUCT_ID for supporting another hardware version of the novatel merlin u740 pcmcia card. It's tested and working fine. Signed-off-by: Nils Neumann <[EMAIL PROTECTED]> --- ./drivers/usb/serial/option.c.orig 2007-03-26 09:13:34.0 +0200 +++ ./drivers/usb/serial/option.c 2007-0

[linux-usb-devel] [PATCH]aircable cleanup

2007-03-26 Thread Oliver Neukum
Hi, - proper endianness macros - scheduling in interrupt in error case Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> -- --- a/drivers/usb/serial/aircable.c 2007-03-26 16:38:47.0 +0200 +++ b/drivers/usb/serial/aircable.c 2007-03-26 16:50

Re: [linux-usb-devel] usbtest test-14 failure: MUSBHDRC + Netchip2280

2007-03-26 Thread Pandita, Vikram
> On Friday 23 March 2007 5:26 am, Pandita, Vikram wrote: > > Hi > > > > I am testing HS USB HOST controller of OMAP2430 (MUSBHDRC) with > > Netchip2280 device using usbtest. When I run the test.sh control test on > > the OMAP Host, the test 14 fails randomly after some iterations with > > error

[linux-usb-devel] pxa270 - USB low speed devices - Maybe the USB cable is bad?

2007-03-26 Thread Girish
Dear All, I am working on pxq270 board. Its up with linux-2.6.20. Currently I am working on USB modules. For Full speed devices ohci driver is able to detect and attach the proper driver. But for low speed devices its giving "*hub 1-0:1.0: Cannot enable port 1. Maybe the USB cable is bad?"*

Re: [linux-usb-devel] [RFC] HID bus design overview.

2007-03-26 Thread Marcel Holtmann
Hi Li, > -- > HID bus design overview. > -- > > A. Terms. > > The device of an driver: this mean the device that this driver matched. > > B. Design. > > As we discussed before, The entire HID subsystem is divid