Re: [linux-usb-devel] [PATCH] appletouch powersaving - please apply for 2.6.23-rc1

2007-07-17 Thread Johannes Berg
Hi, Good stuff :) > + int idlecount; /* number of empty packets */ should probably use tabs here. > + size = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), > +ATP_GEYSER3_MODE_WRITE_REQUEST_ID, > +USB_DIR_

Re: [linux-usb-devel] [PATCH] OHCI: Fix machine check in ohci_hub_status_data

2007-06-08 Thread Johannes Berg
On Fri, 2007-06-08 at 13:47 -0700, Greg KH wrote: > It's in my tree. It will be sent to Linus after 2.6.22 is out. Do you > think it needs to go in before 2.6.22 is final? If so, Alan, do you > agree? Ah ok. Well, I haven't seen the problem without my suspend patch (that hasn't and isn't going

Re: [linux-usb-devel] [PATCH] OHCI: Fix machine check in ohci_hub_status_data

2007-06-08 Thread Johannes Berg
On Fri, 2007-04-20 at 11:33 -0400, Alan Stern wrote: > This patch (as901) fixes an oversight in ohci-hcd. The > hub_status_data routine must not try to access the controller's > memory-mapped registers if the controller is in a low-power state; > such attempts will cause a crash on some architectu

[linux-usb-devel] [PATCH] fix drivers/usb for appletouch

2007-05-02 Thread Johannes Berg
This patch adds drivers/usb/input/ to the build when only APPLETOUCH is selected from the input drivers. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- And I keep wondering why appletouch.ko isn't installed... :) --- wireless-dev.orig/drivers/usb/Makefile 2007-

Re: [linux-usb-devel] Machine check in ohci_hub_status_data (powerpc)

2007-04-20 Thread Johannes Berg
On Wed, 2007-04-18 at 11:42 -0400, Alan Stern wrote: > Something similar needs to be added in ohci-hub.c. Does the patch below > fix your problem? I stuck in a dump_stack() right before the spin_lock_irqsave too to make sure I was hitting the code path at the same spot I analysed at earlier, an

Re: [linux-usb-devel] Machine check in ohci_hub_status_data (powerpc)

2007-04-18 Thread Johannes Berg
On Wed, 2007-04-18 at 02:25 -0700, David Brownell wrote: > On Wednesday 18 April 2007 1:43 am, Johannes Berg wrote: > > > > It seems to me that the timer shouldn't be scheduled when we go into > > suspend, > > Right ... this would be a post-2.6.21 fix right? I

[linux-usb-devel] Machine check in ohci_hub_status_data (powerpc)

2007-04-18 Thread Johannes Berg
Hi, Here's something I just observed yesterday. At first I was blaming my suspend changes for powerpc since I can't make it happen without them, but I've gone back and forth over them and can't find the problem, so while I'm still not sure they aren't at fault I wanted some input from the USB side

[linux-usb-devel] [PATCH] appletouch: fix atp_disconnect

2006-07-19 Thread Johannes Berg
appletouch uses urb->transfer_dma after having freed the urb, this shows up only if the system is compiled with slab debugging. This patch fixes it by reordering the free calls. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- linux-2.6-fetch.orig/drivers/usb/input/appletouch.c 2

Re: [linux-usb-devel] [linux-pm] Remote wake up not working

2006-06-13 Thread Johannes Berg
On Sat, 2006-06-10 at 13:28 +, Pavel Machek wrote: > I do not think we support remote wakeup these days. Code may be there, > but as noone ever uses it... perhaps it needs some fixing. Works fine with bluetooth on my powerbook, but then again, I can't turn it *off* which is rather annoying, b

[linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume

2006-01-18 Thread Johannes Berg
On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote: > This patch is wrong. usb_kill_urb() will sleep. You must not use it under > a spinlock. Whoops. Good catch. I'll have to analyse the logic with the lists being used here (and probably add a temporary list). Will try to get a new patch unti

Re: [linux-usb-devel] USB raw I/O via /dev/usb/ttyUSBxx

2005-09-20 Thread Johannes Berg
On Tue, 2005-09-20 at 10:56 -0600, Jim Jensen wrote: > I'm a retired software developer, somewhat new to Linux--especially > internals. I'm trying to write an application in c++ to operate the new > Meade Instruments Deep Sky Imager (DSI), which is a simple CCD camera > designed for amateur astro

Re: [linux-usb-devel] New driver for Keyspan Digital Media Remote for 2.6.12

2005-06-24 Thread Johannes Berg
On Thu, 2005-06-23 at 16:44 -0600, Michael Downey wrote: > I'm using Thunderbird and can't figure out how to inline attachments so > I'm pasting it here: Unfortunately, this (I guess) caused the patch to word-wrap. At least it appears word-wrapped here. johannes signature.asc Description: This

Re: [linux-usb-devel] problem with usb keyboard device.

2005-06-13 Thread Johannes Berg
On Mon, 2005-06-13 at 11:13 +0530, vishal wrote: > #insmod usbkbd.o Try not loading this. usbhid should handle the kb. johannes signature.asc Description: This is a digitally signed message part

Re: [linux-usb-devel] hiddev question

2005-06-09 Thread Johannes Berg
Jeff Lange wrote: Johannes, the device is fully HID compliant, it is just a vendor defined usage. The reason for this was to make Windows driver a lot easier to write. I think I'm just going to have to write my own kernel driver for this thing and create a char dev that my app can read the dat

Re: [linux-usb-devel] hiddev question

2005-06-08 Thread Johannes Berg
On Wed, 2005-06-08 at 12:37 -0400, Jeff Lange wrote: > I'm developing a simple USB device that reports itself as a HID > device, and uses interrupt transfers to send about 250 bytes of data > whenever an event occurs on the device. Why do you do this as opposed to *not* identifying as a HID dev

Re: [linux-usb-devel] usb enumeration problem on new powerbook

2005-04-18 Thread Johannes Berg
On Mon, 2005-04-18 at 12:03 -0400, Alan Stern wrote: > All I can is, this seems to be a pretty finicky device. Of course, it's > always possible that the problem lies not in the device but in the host > controller. Have you tried plugging it into any of the other controllers > on your compute

Re: [linux-usb-devel] usb enumeration problem on new powerbook

2005-04-18 Thread Johannes Berg
On Fri, 2005-04-15 at 23:15 -0400, Alan Stern wrote: > It would help if you set CONFIG_USB_DEBUG and provided a system log > showing what happens when the bluetooth device is enumerated. I have attached a three startup logs (dmesg) with CONFIG_USB_DEBUG. The relevant device is on 0001:10:1a.0/us

[linux-usb-devel] usb enumeration problem on new powerbook

2005-04-15 Thread Johannes Berg
Hi, I *finally* managed to get the internal bluetooth device on the new PowerBook (post February 2005) working... ... by loading usbcore with 'use_both_schemes=1 old_scheme_first=1' I assumed the device is quirky and nothing more, but BenH told me to come here. Any details should be on http://jo

[linux-usb-devel] submitting usbhid quirks?

2005-04-08 Thread Johannes Berg
Hi, I've got the new PowerBook5,6 whose FN key is sending EV_ABS instead of EV_KEY events, so I added a quirk for it. (see http://johannes.sipsolutions.net/PowerBook/special_buttons) Where do I send the patch for inclusion? johannes signature.asc Description: This is a digitally signed message

Re: [linux-usb-devel] device driver problems

2005-04-07 Thread Johannes Berg
On Thu, 2005-04-07 at 13:18 +, tarun bhandari wrote: > the file attach consist of my problems associated with my problems Please re-send in a format suitable for email, otherwise you'll probably just be ignored. johannes signature.asc Description: This is a digitally signed message part

Re: [linux-usb-devel] differences between 2.6.10 and .11?

2005-04-04 Thread Johannes Berg
On Mon, 2005-04-04 at 14:06 -0700, David Brownell wrote: > That's exactly as I described. 64 bytes in one packet, 17 in the next. > > You are NOT getting 81 bytes in one frame/packet!! Ok, thanks for clarifying. > > I suppose if I told the kernel I want 40 bytes it'd give me 40, then 40 > > an

Re: [linux-usb-devel] differences between 2.6.10 and .11?

2005-04-04 Thread Johannes Berg
On Mon, 2005-04-04 at 13:22 -0700, David Brownell wrote: > > If I pass a URB into the usb layer that has an 81 byte buffer, all those > > 81 bytes get filled! > > Probably the first 64 in one frame, then the last bytes in the next one > that's polled. That's expected ... otherwise drivers would

Re: [linux-usb-devel] differences between 2.6.10 and .11?

2005-04-04 Thread Johannes Berg
On Mon, 2005-04-04 at 15:31 -0400, Alan Stern wrote: > For full-speed devices that's right. For low-speed devices the upper > limit is 8, and for high-speed it's 1024. Yeah, that's what I read from the spec too, thanks for confirming. > What makes you think the value > should be 81? Didn't

Re: [linux-usb-devel] differences between 2.6.10 and .11?

2005-04-04 Thread Johannes Berg
On Fri, 2005-04-01 at 11:47 -0500, Alan Stern wrote: > There's a very simple explanation. In 2.6.10 and earlier the > wMaxPacketSize value is stored in native byte order, whereas in 2.6.11 and > later it's stored in little-endian byte order. So your code is getting > the correct value under 2

[linux-usb-devel] differences between 2.6.10 and .11?

2005-03-31 Thread Johannes Berg
Hi, I have this little driver for the new PowerBook's trackpad (all on http://johannes.sipsolutions.net/PowerBook/touchpad/driver) Currently, it does nothing much but submit URBs and push the received data into userspace, I built it based on usb-skeleton.c. Once userspace reads the data, it resub

Re: [linux-usb-devel] [PATCH] USB: rewrite the usblcd driver

2005-03-31 Thread Johannes Berg
On Thu, 2005-03-31 at 01:05 +0200, Georges Toth wrote: > Maybe 1.0 would be better (1.0, because the driver is ready for production, > and no beta-ware) > > What do you think ? Personally, I think 1.0 < 1.05 so that has a weird feel to it as well. I guess I'd just call it 2.0 ;) johannes sig

Re: [linux-usb-devel] [PATCH] USB: rewrite the usblcd driver

2005-03-30 Thread Johannes Berg
On Wed, 2005-03-30 at 13:48 -0800, Greg KH wrote: > -#define DRIVER_VERSION "USBLCD Driver Version 1.04" > +#define DRIVER_VERSION "USBLCD Driver Version 1.05" If it is a complete rewrite, wouldn't a new version number be appropriate? I don't know if this ever makes it to userspace (didn't check

Re: [linux-usb-devel] Reverse Engineering FM Whale Mouse

2005-03-30 Thread Johannes Berg
On Wed, 2005-03-30 at 09:52 -0500, jklaas wrote: > Can this be done with a regular module or driver? I'll start looking > into doing the libusb driver. As Jan Merka wrote: use usb_detach_kernel_driver_np > Is it possible to create a v4l radio interface with a libusb driver? I'd guess not, but

Re: [linux-usb-devel] Reverse Engineering FM Whale Mouse

2005-03-30 Thread Johannes Berg
On Tue, 2005-03-29 at 22:08 -0500, jklaas wrote: > Well, it's not a driver as far as I can tell. At least for the radio > part. The mouse part runs fine under the normal windows HID driver. > Then there's this radio program that uses this radio.dll. There's a > bunch of init stuff, about 9 URBs

Re: [linux-usb-devel] Reverse Engineering FM Whale Mouse

2005-03-29 Thread Johannes Berg
On Tue, 2005-03-29 at 16:16 -0500, jklaas wrote: > I have another question that I don't quite understand. With the FM Radio > the TransferBufferLength in the URB going down is usually either 0x16 or > 0xca. The URB coming back has the TransferBufferLength is 0x06. I > guess I don't quite underst

Re: [linux-usb-devel] Reverse Engineering FM Whale Mouse

2005-03-29 Thread Johannes Berg
On Tue, 2005-03-29 at 12:08 -0500, jklaas wrote: > Being a usb gadget freak, I bought this combo mouse and usb controlled > FM Radio for cheap ($10 + shipping). It looks really neat, and I pretty > much figured out how to get the radio to work. Neat. > I was wondering if there was any way to get

[linux-usb-devel] Re: speedstep-smi on PIII sometimes makes USB mad

2004-10-29 Thread Johannes Berg
On Sun, 2004-10-24 at 12:51 -0400, Alan Stern wrote: > I'm rather surprised that it managed to work after you plugged the mouse > back in. :-) It does without problems though, repeatably (whenever I get this, I don't use my USB mouse much) > Anyway, I don't see what can be done about it. The "