Re: [linux-usb-devel] [PATCH]allocation of buffer in appletouch

2006-10-07 Thread Nicolas Boichat
Hi, Oliver Neukum wrote: > Hi, > > allocating a buffer with usb_buffer_alloc() is pointless if you don't > set transfer_flags. > Again, I'm not responsible of that part of the code. I cc'ed two people (Stelian Pop and Johannes Berg), who gave a lot of input when I submitted my patch... Best re

Re: [linux-usb-devel] race in appletouch

2006-10-07 Thread Nicolas Boichat
Hello, Oliver Neukum wrote: > Hi, > > in the appletouch driver open() races with suspend(). This should > fix it. Nicolas, could you please test it? > I applied the patch, loaded the driver, and it works. I don't know how to reproduce the initial bug, so I cannot test it more precisely. (I'm us

[linux-usb-devel] Re: [PATCH] MacBook Pro touchpad support

2006-04-20 Thread Nicolas Boichat
On Wed, 2006-04-19 at 12:50 -0700, Greg KH wrote: > On Wed, Apr 19, 2006 at 01:33:52PM +0200, Nicolas Boichat wrote: > > - dprintk("appletouch: incomplete data package.\n"); > > + dprintk("appletouch: incomplete data package (first byte: %d, &g

[linux-usb-devel] [PATCH] MacBook Pro touchpad support

2006-04-20 Thread Nicolas Boichat
Hi Greg, Here is a fixed version of my patch, using u16 instead of int. Best regards, Nicolas --- From: Nicolas Boichat <[EMAIL PROTECTED]> Add support for MacBook touchpad in appletouch driver. Thanks to Alex Harper for the informations. Use u16 instead of int16_t in atp_is_

[linux-usb-devel] [PATCH] MacBook Pro touchpad support

2006-04-18 Thread Nicolas Boichat
From: Nicolas Boichat <[EMAIL PROTECTED]> Add support for MacBook touchpad in appletouch driver. Thanks to Alex Harper for the informations. Acked-by: Johannes Berg <[EMAIL PROTECTED]> Acked-by: Stelian Pop <[EMAIL PROTECTED]> Signed-off-by: Nicolas Boichat <[EMAIL PROTECT