Re: [linux-usb-devel] [PATCH][RFC] switch ehci-hcd to new polling scheme

2007-01-04 Thread Alan Stern
On Wed, 3 Jan 2007, David Brownell wrote: > On Friday 29 December 2006 11:26 am, Marcelo Tosatti wrote: > > > > > > How about this, then: > > > > > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > > index 025d333..5c90bde 100644 > > --- a/drivers/usb/host/ehci-hcd.c >

Re: [linux-usb-devel] [PATCH][RFC] switch ehci-hcd to new polling scheme

2007-01-03 Thread David Brownell
On Thursday 28 December 2006 9:33 am, Marcelo Tosatti wrote: > Hi, > > The root hub status timer is problematic for tickless systems. Yes. Most of them (by number) being on ARM, using OHCI, which is why that driver got converted to non-polled operation already. :) Root hub polling is largely a

Re: [linux-usb-devel] [PATCH][RFC] switch ehci-hcd to new polling scheme

2007-01-03 Thread David Brownell
On Friday 29 December 2006 11:26 am, Marcelo Tosatti wrote: > > > How about this, then: > > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 025d333..5c90bde 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -496,6 +496,9 @@ stat

Re: [linux-usb-devel] [PATCH][RFC] switch ehci-hcd to new polling scheme

2006-12-30 Thread Alan Stern
On Fri, 29 Dec 2006, Marcelo Tosatti wrote: > How about this, then: > > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 025d333..5c90bde 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -496,6 +496,9 @@ static int ehci_run (stru

Re: [linux-usb-devel] [PATCH][RFC] switch ehci-hcd to new polling scheme

2006-12-29 Thread Marcelo Tosatti
> > Due to that, I've moved the call to a workqueue instance. > > You can avoid using a workqueue by calling usb_hcd_poll_rh_status() at the > end of ehci_irq(), after the spinlock has been released. Doing an extra > test of the STS_PCD bit is a lot less overhead than starting up a > workqueu

Re: [linux-usb-devel] [PATCH][RFC] switch ehci-hcd to new polling scheme

2006-12-28 Thread Alan Stern
On Thu, 28 Dec 2006, Marcelo Tosatti wrote: > Greg added code to make the interrupt handler of the host controller > inform status change events, making polling unnecessary during normal > operation (new_polling flag). > > OHCI and UHCI have been converted to the new scheme, but EHCI hasnt. > >

[linux-usb-devel] [PATCH][RFC] switch ehci-hcd to new polling scheme

2006-12-28 Thread Marcelo Tosatti
Hi, The root hub status timer is problematic for tickless systems. -bash-3.1# echo 1 > timer_stats ; sleep 5s ; cat timer_stats Timer Stats Version: v0.1 Sample period: 5.014 s 2, 0 swapper hrtimer_restart_sched_tick (hrtimer_sched_tick) 25, 1 swapper fbcon_add_curs