On Friday 25 May 2007, Tony Lindgren wrote:
+
Mostly this patch just seems to move a block of code into a
standalone function, removing some nesting ... which is OK
as a cleanup, but makes it hard to see the substantive changes
in this routine.
So it'd be best to see a minimal patch just fixing
* David Brownell [EMAIL PROTECTED] [070529 12:18]:
On Friday 25 May 2007, Tony Lindgren wrote:
+
Mostly this patch just seems to move a block of code into a
standalone function, removing some nesting ... which is OK
as a cleanup, but makes it hard to see the substantive changes
in this
* David Brownell [EMAIL PROTECTED] [070529 16:04]:
On Tuesday 29 May 2007, Tony Lindgren wrote:
snip snip snip snip
- Enable HNP early (later would be OK too);
- Offer to do HNP if the peripheral wants to use it
Host doesn't know anything about peripheral wants;
from its perspective,
On 5/30/07, Tony Lindgren [EMAIL PROTECTED] wrote:
* David Brownell [EMAIL PROTECTED] [070529 16:04]:
On Tuesday 29 May 2007, Tony Lindgren wrote:
snip snip snip snip
- Enable HNP early (later would be OK too);
- Offer to do HNP if the peripheral wants to use it
Host doesn't know
On Tuesday 29 May 2007, Tony Lindgren wrote:
* David Brownell [EMAIL PROTECTED] [070529 12:18]:
On Friday 25 May 2007, Tony Lindgren wrote:
+
So it'd be best to see a minimal patch just fixing any bugs...
Those substantive changes unfortunately include inserting
bugs ... which
* David Brownell [EMAIL PROTECTED] [070529 16:04]:
On Tuesday 29 May 2007, Tony Lindgren wrote:
I see your point though with autoidle, but that's after
the devices have enumerated the wrong way, right?
You want me to look at that code again? Aargh!
Originally there was no autoidle,
snip
The behavioral difference would be that WHEN (not 'IF')
the whitelist (which is very easily checked against product
documentation) diverges from the list of configured drivers
(no easy way to crosscheck that and docs) things would not
act the same.
I guess HNP should be offered
* Felipe Balbi [EMAIL PROTECTED] [070529 16:34]:
snip
The behavioral difference would be that WHEN (not 'IF')
the whitelist (which is very easily checked against product
documentation) diverges from the list of configured drivers
(no easy way to crosscheck that and docs) things would not
* Alan Stern [EMAIL PROTECTED] [070525 14:09]:
On Fri, 25 May 2007, David Brownell wrote:
You omitted the (except as noted in Section 3.8), which says
that a second connector is allowed iff it's a Mini-A connector.
That's a trivial counter-example...
But in any case, section 3 is
