Re: [linux-usb-devel] [PATCH] use kref in ehci

2004-04-27 Thread Greg KH
On Tue, Apr 27, 2004 at 06:49:36PM +0200, Oliver Neukum wrote: > Am Dienstag, 27. April 2004 17:53 schrieb Greg KH: > > - atomic_read (&qh->refcount), ehci->periodic_sched); > > + atomic_read (&qh->kref.refcount), ehci->periodic_sched); > > This is ugly. If you are usin

Re: [linux-usb-devel] [PATCH] use kref in ehci

2004-04-27 Thread Oliver Neukum
Am Dienstag, 27. April 2004 17:53 schrieb Greg KH: > - atomic_read (&qh->refcount), ehci->periodic_sched); > + atomic_read (&qh->kref.refcount), ehci->periodic_sched); This is ugly. If you are using an opaque data structure, keep it opaque. Regards

[linux-usb-devel] [PATCH] use kref in ehci

2004-04-27 Thread Greg KH
Hi, Here's a patch against 2.6.6-rc2 that replaces the use of atomic_t in the ehci driver with a kref. It builds for for me here, any objections to me adding it to the main kernel tree? thanks, greg k-h = drivers/usb/host/ehci-hcd.c 1.113 vs edited = --- 1.113/drivers/usb/host/ehci-hc