--- local_tree.orig/drivers/usb/core/devio.c    2004-07-26 00:17:25.499847408 +0200
+++ local_tree/drivers/usb/core/devio.c 2004-07-26 00:23:41.914115079 +0200
@@ -1102,18 +1102,28 @@
 {
        struct async *as;
        void __user *addr;
+       struct usb_device *dev = ps->dev;
        int ret;
 
-       if (!(as = async_getcompleted(ps)))
-               return -EAGAIN;
+       down(&dev->serialize);
+       if (!connected(dev)) {
+               ret = -ENODEV;
+               goto fail;
+       }
+       if (!(as = async_getcompleted(ps))) {
+               ret = -EAGAIN;
+               goto fail;
+       }
        ret = processcompl(as);
        addr = as->userurb;
        free_async(as);
        if (ret)
-               return ret;
-       if (put_user(addr, (void __user * __user *)arg))
-               return -EFAULT;
-       return 0;
+               goto fail;
+       up(&dev->serialize);
+       return put_user(addr, (void __user * __user *)arg) ? -EFAULT : 0;
+fail:
+       up(&dev->serialize);
+       return ret;
 }
 
 static int proc_disconnectsignal(struct dev_state *ps, void __user *arg)
@@ -1336,14 +1346,8 @@
                break;
 
        case USBDEVFS_REAPURBNDELAY:
-               down(&dev->serialize);
-               if (!connected(dev)) {
-                       up(&dev->serialize);
-                       return -ENODEV;
-               }
                snoop(&dev->dev, "%s: REAPURBDELAY\n", __FUNCTION__);
                ret = proc_reapurbnonblock(ps, p);
-               up(&dev->serialize);
                break;
 
        case USBDEVFS_DISCSIGNAL:


-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to