On Tuesday 31 October 2006 5:23 pm, Adrian Bunk wrote:
select MII if USB_NET_AX8817X!=n || USB_NET_MCS7830!=n
Thing is, I'm seeing that get morphed inside Kconfig to select MII in
some cases ... the if x != n gets ignored, MII can't be deselected.
That looks to me like a Kconfig
On Wednesday 01 November 2006 11:15 pm, Greg KH wrote:
Argh, there were just too many different versions of these patches
floating around. Can you resend the final versions please?
This should replace BOTH of Randy's patches. It addresses all the
issues I've heard raised, and resolves the
On Thu, Nov 02, 2006 at 12:29:12PM -0800, David Brownell wrote:
On Wednesday 01 November 2006 11:15 pm, Greg KH wrote:
Argh, there were just too many different versions of these patches
floating around. Can you resend the final versions please?
This should replace BOTH of Randy's
On Thursday 02 November 2006 6:27 pm, Adrian Bunk wrote:
It seems to lack the select MII at the USB_RTL8150 option that was in
Randy's first patch?
I was just addressing the usbnet issues ... that driver doesn't
use the usbnet framework.
- Dave
On Thu, 2 Nov 2006, David Brownell wrote:
On Thursday 02 November 2006 6:27 pm, Adrian Bunk wrote:
It seems to lack the select MII at the USB_RTL8150 option that was in
Randy's first patch?
I was just addressing the usbnet issues ... that driver doesn't
use the usbnet framework.
and
On Tue, Oct 31, 2006 at 11:36:52AM -0800, David Brownell wrote:
...
depends on MII if MII != n
except that Kconfig doesn't comprehend conditionals like that.
You can express this in Kconfig:
depends MII || MII=n
Except that:
Warning! Found
On Wed, Oct 25, 2006 at 07:22:08PM -0700, David Brownell wrote:
On Wednesday 25 October 2006 4:58 pm, Randy Dunlap wrote:
On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote:
Instead, usbnet.c should #ifdef the relevant ethtool hooks
according to CONFIG_MII ... since it's
+#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE)
+#define HAVE_MII
...
This seems to cause a CONFIG_USB_USBNET=y, CONFIG_MII=m breakage
(as already described earlier in this thread)?
Well, alluded to not described. Fixable by the equivalent of
config USB_USBNET
On Tue, Oct 31, 2006 at 10:40:15AM -0700, David Brownell wrote:
+#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE)
+#define HAVE_MII
...
This seems to cause a CONFIG_USB_USBNET=y, CONFIG_MII=m breakage
(as already described earlier in this thread)?
Well, alluded to not
...
depends on MII if MII != n
except that Kconfig doesn't comprehend conditionals like that.
You can express this in Kconfig:
depends MII || MII=n
Except that:
Warning! Found recursive dependency: USB_USBNET USB_NET_AX8817X MII USB_USBNET
I think
On Sat, Oct 28, 2006 at 02:10:09PM -0700, David Brownell wrote:
On Saturday 28 October 2006 4:21 am, Christoph Hellwig wrote:
This is really awkward and against what we do in any other driver.
Awkward, yes -- which is why I posted the non-awkward version,
which is repeated below. (No
On Wed, Oct 25, 2006 at 04:58:58PM -0700, Randy Dunlap wrote:
...
Build tested with CONFIG_MII=y, m, n.
...
--- linux-2619-rc3-pv.orig/drivers/usb/net/usbnet.c
+++ linux-2619-rc3-pv/drivers/usb/net/usbnet.c
@@ -47,6 +47,12 @@
#define DRIVER_VERSION 22-Aug-2005
+#if
Adrian Bunk wrote:
On Wed, Oct 25, 2006 at 04:58:58PM -0700, Randy Dunlap wrote:
...
Build tested with CONFIG_MII=y, m, n.
...
--- linux-2619-rc3-pv.orig/drivers/usb/net/usbnet.c
+++ linux-2619-rc3-pv/drivers/usb/net/usbnet.c
@@ -47,6 +47,12 @@
#define DRIVER_VERSION
On Saturday 28 October 2006 4:21 am, Christoph Hellwig wrote:
This is really awkward and against what we do in any other driver.
Awkward, yes -- which is why I posted the non-awkward version,
which is repeated below. (No thanks to diff for making the
patch ugly though; the resulting code is
On Sat, Oct 28, 2006 at 02:10:09PM -0700, David Brownell wrote:
On Saturday 28 October 2006 4:21 am, Christoph Hellwig wrote:
This is really awkward and against what we do in any other driver.
Awkward, yes -- which is why I posted the non-awkward version,
which is repeated below. (No
On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote:
Instead, usbnet.c should #ifdef the relevant ethtool hooks
according to CONFIG_MII ... since it's completely legit to
use usbnet with peripherals that don't need MII.
---
From: Randy Dunlap [EMAIL PROTECTED]
usbnet driver should use
On Wednesday 25 October 2006 4:58 pm, Randy Dunlap wrote:
On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote:
Instead, usbnet.c should #ifdef the relevant ethtool hooks
according to CONFIG_MII ... since it's completely legit to
use usbnet with peripherals that don't need MII.
I had
17 matches
Mail list logo
