Re: [linux-usb-devel] [RFC][PATCH] AIRcable USB Bluetooth Dongle Driver Revision 2

2006-07-08 Thread Oliver Neukum
Am Sonntag, 9. Juli 2006 01:10 schrieb Naranjo Manuel Francisco: > Ok Oliver I will correct that. > Do you think the rest is ok? No, I overlooked a few things somebody else noticed. Regards Oliver -

Re: [linux-usb-devel] [RFC][PATCH] AIRcable USB Bluetooth Dongle Driver Revision 2

2006-07-08 Thread Luiz Fernando N. Capitulino
Hi Manuel, On Sat, 8 Jul 2006 15:27:22 -0300 "Naranjo Manuel Francisco" <[EMAIL PROTECTED]> wrote: | Signed-off-by: Naranjo, Manuel Francisco <[EMAIL PROTECTED]> | | diff -uprN -X linux-vanilla/Documentation/dontdiff | linux-vanilla/drivers/usb/serial/aircable.c | linux/drivers/usb/serial/airc

Re: [linux-usb-devel] [RFC][PATCH] AIRcable USB Bluetooth Dongle Driver Revision 2

2006-07-08 Thread Naranjo Manuel Francisco
Ok Oliver I will correct that. Do you think the rest is ok? 2006/7/8, Oliver Neukum <[EMAIL PROTECTED]>: > > > + if (num_bulk_out == 0) { > > + dbg("Invalid interface, discarding.\n"); > > + return ENODEV; > > return -ENODEV; > > error returns are negative > > > > +

Re: [linux-usb-devel] [RFC][PATCH] AIRcable USB Bluetooth Dongle Driver Revision 2

2006-07-08 Thread Oliver Neukum
> + if (num_bulk_out == 0) { > + dbg("Invalid interface, discarding.\n"); > + return ENODEV; return -ENODEV; error returns are negative > + data = kmalloc(package_length - > HCI_HEADER_LENGTH, GFP_ATOMIC); must check for allocation fail

[linux-usb-devel] [RFC][PATCH] AIRcable USB Bluetooth Dongle Driver Revision 2

2006-07-08 Thread Naranjo Manuel Francisco
Hi: I made the changes suggested by Greg and Oliver. I have some strong changes to my driver. I have been reading the FTDI driver and taken some ideas from there. I think that the bug is corrected, I have been able to transfer 300 bytes without problem. Even more I have reached the hardware limit,