Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-31 Thread Christopher Montgomery
On 8/30/06, David Brownell [EMAIL PROTECTED] wrote: On Wednesday 30 August 2006 4:36 pm, Christopher Montgomery wrote: I'd not normally complain, but I'll need to do addiitonal work and release an all new patchset of the ehci-scheduler... just to deal with cosmetic whitespace changes?

Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-31 Thread Greg KH
On Thu, Aug 31, 2006 at 01:08:19PM -0400, Christopher Montgomery wrote: On 8/30/06, David Brownell [EMAIL PROTECTED] wrote: On Wednesday 30 August 2006 4:36 pm, Christopher Montgomery wrote: I'd not normally complain, but I'll need to do addiitonal work and release an all new patchset

Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-31 Thread Christopher Montgomery
On 8/31/06, Greg KH [EMAIL PROTECTED] wrote: Does this patch conflict with yours? I read the first few pages, it does. However, something massively messed the size of the thing when I saved it out to read in emacs. I thought this was a 10,000 line or so patch. it isn't; it's relatively

Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-31 Thread David Brownell
I'm committed to seeing this patch to either oblivion or production, and globally altering whitespace is going to blow my time for *no net benefit to anyone*. Cleanups like these _do_ have benefit. If you really are that wholly uninterested in a complete scheduler, You're

Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-31 Thread David Brownell
You're overreacting more than a little bit. We want that, and also want good clean code. It's not as if this patch was submitted to annoy you (or anyone). Yep, I certainly was. Apology might not have made it to the list yet. I got it later ... accepted. I try to

Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-31 Thread Greg KH
On Thu, Aug 31, 2006 at 01:27:08PM -0400, Christopher Montgomery wrote: On 8/31/06, Greg KH [EMAIL PROTECTED] wrote: Does this patch conflict with yours? I read the first few pages, it does. However, something massively messed the size of the thing when I saved it out to read in

Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-31 Thread Christopher Montgomery
On 8/31/06, David Brownell [EMAIL PROTECTED] wrote: I'm committed to seeing this patch to either oblivion or production, and globally altering whitespace is going to blow my time for *no net benefit to anyone*. Cleanups like these _do_ have benefit. Never said otherwise. I'd objected for

[linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-30 Thread David Brownell
[ ... when you have an editor set to remind you of whitespace bugs ... ] Cosmetic EHCI changes: remove end-of-line whitespace, spaces before tabs. Signed-off-by: David Brownell [EMAIL PROTECTED] Index: g26/drivers/usb/host/ehci.h

Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-30 Thread Christopher Montgomery
I'd not normally complain, but I'll need to do addiitonal work and release an all new patchset of the ehci-scheduler... just to deal with cosmetic whitespace changes? Monty - Using Tomcat but need to do more? Need to

Re: [linux-usb-devel] [patch 2.6.18-rc5] EHCI whitespace fixes (cosmetic)

2006-08-30 Thread David Brownell
On Wednesday 30 August 2006 4:36 pm, Christopher Montgomery wrote: I'd not normally complain, but I'll need to do addiitonal work and release an all new patchset of the ehci-scheduler... just to deal with cosmetic whitespace changes? Not until 2.6.18-early, no. At which point it's