Re: [linux-usb-devel] [patch 2.6.23-rc1-git] ohci-hcd works around more Compaq/ZF-Micro quirks

2007-07-26 Thread Mike Nuss
David Brownell wrote: The worst case should be seven frames (maximum time any WDH irq would be deferred) and two WDH irqs. That would even cover that mostly-safe assumption that multi-TD interrupt transfers aren't happening (they're pretty rare with full speed hardware). I know now that

[linux-usb-devel] [patch 2.6.23-rc1-git] ohci-hcd works around more Compaq/ZF-Micro quirks

2007-07-25 Thread David Brownell
From: Mike Nuss [EMAIL PROTECTED] The ZF Micro OHCI controller exhibits unexpected behavior that seems to be related to high load. Under certain conditions, the controller will complete a TD, remove it from the endpoint's queue, and fail to add it to the donelist. This causes the endpoint to

Re: [linux-usb-devel] [patch 2.6.23-rc1-git] ohci-hcd works around more Compaq/ZF-Micro quirks

2007-07-25 Thread David Brownell
On Wednesday 25 July 2007, Mike Nuss wrote: David Brownell wrote: This fix enhances the scope of the existing OHCI_QUIRK_ZFMICRO flag: 1. A watchdog routine periodically scans the OHCI structures to check for orphaned TDs. In these cases the TD is taken back from the

Re: [linux-usb-devel] [patch 2.6.23-rc1-git] ohci-hcd works around more Compaq/ZF-Micro quirks

2007-07-25 Thread Greg KH
On Wed, Jul 25, 2007 at 01:13:39PM -0700, David Brownell wrote: On Wednesday 25 July 2007, Mike Nuss wrote: Either way, this patch in its current form isn't safe. Darn. OK, I'm sure Greg will know not to merge it. Yup, consider it dropped, thanks for letting me know. thanks, greg k-h

Re: [linux-usb-devel] [patch 2.6.23-rc1-git] ohci-hcd works around more Compaq/ZF-Micro quirks

2007-07-25 Thread Mike Nuss
David Brownell wrote: This fix enhances the scope of the existing OHCI_QUIRK_ZFMICRO flag: 1. A watchdog routine periodically scans the OHCI structures to check for orphaned TDs. In these cases the TD is taken back from the controller and completed normally. Of course, just after

Re: [linux-usb-devel] [patch 2.6.23-rc1-git] ohci-hcd works around more Compaq/ZF-Micro quirks

2007-07-25 Thread Alan Stern
On Wed, 25 Jul 2007, Mike Nuss wrote: 2. The logic is too naive. The quirk assumes that if HeadP and DoneP remain equal (meaning that the HC's queue is empty) for at least one frame, but the HCD still sees an outstanding TD, then that TD must be lost. But it may be that even though the queue