Re: [linux-usb-devel] Character gadget

2005-10-29 Thread Alan Stern
On Sat, 29 Oct 2005, Joshua Wise wrote: > >>req->zero = (req->actual < req->length); > > There's no point setting req->zero for an OUT transfer. > Okay. I have no idea what req->zero actually does. I think I grabbed it from > zero.c. Does req->zero mean "send a ZLP at the end"?

Re: [linux-usb-devel] Character gadget

2005-10-29 Thread Joshua Wise
Here are a few comments, mixed in with your code. Thanks! #define DBUFMAX 65536 This is pretty big for a kernel buffer. You ought to be able to use something smaller. I agree. I dropped it to 8k, which is a nicer size -- It gives me about seven YMODEM-1k packets. It's not clear that these

Re: [linux-usb-devel] Character gadget

2005-10-29 Thread Alan Stern
On Sat, 29 Oct 2005, Joshua Wise wrote: > I understand that it'll probably not be ready for a commit now, but it's a > lot cleaner than it used to be. Can someone run a pair of eyes over it and > tell me if anything is glaringly preventing it from going into the tree? Here are a few comments, mix

[linux-usb-devel] Character gadget

2005-10-29 Thread Joshua Wise
Hi all, Over the past few years, handhelds.org has been maintaining a small gadget inside of its own tree called "g_char". g_char was spawned in the days before g_serial, as a response to the new USB gadget API's replacement of the old way of doing things (usb_char talking to gadget controller dr