Re: [linux-usb-devel] Extension for auerswald driver to include ISDN modem functions

2003-01-26 Thread Wolfgang Mües
Hello David, On Sunday 26 January 2003 20:38, David Brownell wrote: > Wolfgang Mües wrote: > > There are more workarounds in this driver: there was a requirement > > of one-shot INT OUT urbs, with individual byte counts. Manage this > > to work with 3 different core drivers was difficult. > > Than

Re: [linux-usb-devel] Extension for auerswald driver to include ISDN modem functions

2003-01-12 Thread Wolfgang Mües
Hello Oliver, > If you feel you need to emulate functionality the core should have, the > core should have that functionality. So go hence and expand the core :-) Ideally, yes. But this is a huge job for my limited understanding of usb core internals. The auerswald driver has started as a sepera

Re: [linux-usb-devel] Extension for auerswald driver to include ISDN modem functions

2003-01-12 Thread Oliver Neukum
> > int auerchain_unlink_urb(struct auerchain *acp, struct urb *urb) > > + spin_unlock_irqrestore(&acp->lock, flags); > > + dbg("unlink waiting urb"); > > + urb->status = -ENOENT; > > + urb->complete(urb); > > Please no. Don't

Re: [linux-usb-devel] Extension for auerswald driver to include ISDN modem functions

2003-01-12 Thread Wolfgang Mües
Hello Oliver, I know I can count on you ;-) Thank you for reviewing. On Sunday 12 January 2003 16:47, Oliver Neukum wrote: > void auerbuf_free(struct auerbuf *bp) > - simply do kfree. It's officially allowed to pass NULL. There's no need > to burn cycles OK. I have changed all occurances. I d

Re: [linux-usb-devel] Extension for auerswald driver to include ISDN modem functions

2003-01-12 Thread Oliver Neukum
Am Sonntag, 12. Januar 2003 14:58 schrieb Wolfgang Mües: > Hello, > > this is the updated auerswald driver on top of 2.4.20. Does anybody wants > to have a look at it for review? I am very shure I have missed something. > > best regards > Wolfgang Mües void auerbuf_free(struct auerbuf *bp) - simpl

[linux-usb-devel] Extension for auerswald driver to include ISDN modem functions

2003-01-12 Thread Wolfgang Mües
Hello, this is the updated auerswald driver on top of 2.4.20. Does anybody wants to have a look at it for review? I am very shure I have missed something. best regards Wolfgang Mües auerisdn_12012003.tgz Description: application/tgz