Re: [linux-usb-devel] Make usb quieter during boot

2001-06-07 Thread Greg KH
On Thu, Jun 07, 2001 at 12:18:06PM -0700, Mark McClelland wrote: > Hmm, why not description + version? It seems a bit easier to read, > which translates to less-confusing-to-users, which is good for everyone. I agree. Xavier sent me the following patch that does just that. Look good for every

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-07 Thread David Brownell
This one's OK by me, though it's "version first" (which I prefer, Mark's example notwithstanding). - Original Message - From: "Greg KH" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, June 07, 2001 2:11 PM Subject: Re: [linux

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-07 Thread David Brownell
, at least let's focus on the information that's actually useful when troubleshooting! - Dave - Original Message - From: "Pete Zaitcev" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, June 07, 2001 10:59 AM Subject: Re: [linux-usb-devel] Make

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-07 Thread Mark McClelland
David Brownell wrote: >Yes, please. So the patch from xavyer was OK except >the version + description string should be info() not dbg () ... >that's a simple edit to his patch. > Hmm, why not description + version? It seems a bit easier to read, which translates to less-confusing-to-users, whi

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-07 Thread Pete Zaitcev
PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Thursday, June 07, 2001 10:59 AM > Subject: Re: [linux-usb-devel] Make usb quieter during boot > > >... > > > > Let us keep versions, if they are really needed, but remove > > authors and miscalleneou

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-07 Thread Pete Zaitcev
> From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Jun 2001 22:33:31 -0700 >[...] > No, I would argue against this. I think the modules need to identify > themselves when they are loaded. Exactly like all of the ethernet > drivers do. This was something that was talked about at the Linux 2.5 >

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-06 Thread Greg KH
On Wed, Jun 06, 2001 at 10:22:27PM -0700, xavyer wrote: > The attached patch is against linux-2.4.6-pre1. > > This changes instances of: > > info(DRIVER_VERSION " " DRIVER_AUTHOR); > info(DRIVER_DESC); > > to: > > dbg(DRIVER_VERSION ":" DRIVER_DESC); No, I would argue agains

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-06 Thread xavyer
On Wed, 6 Jun 2001, David Brownell wrote: | > I think that quite a bunch of others could be turned into dbg's, like | > the 'skipped descriptor' one and a lot in hub.c ... | | Any new developers feel like starting with some kernel janitor sorts | of tasks, which make a visible difference? :) |

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-06 Thread David Brownell
> I think that quite a bunch of others could be turned into dbg's, like > the 'skipped descriptor' one and a lot in hub.c ... Any new developers feel like starting with some kernel janitor sorts of tasks, which make a visible difference? :) - Dave

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-06 Thread Vojtech Pavlik
On Wed, Jun 06, 2001 at 12:20:28PM -0400, Pete Zaitcev wrote: > > From: Pavel Machek <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED], > >Linux usb mailing list <[EMAIL PROTECTED]> > > Date: Tue, 5 Jun 2001 22:35:55 +0200 > > > During boot, usb produces useless messages. Here's patch to kill th

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-06 Thread Pete Zaitcev
> From: Pavel Machek <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED], >Linux usb mailing list <[EMAIL PROTECTED]> > Date: Tue, 5 Jun 2001 22:35:55 +0200 > During boot, usb produces useless messages. Here's patch to kill them. I strongly agree, especially with the last one: > --- clean/drivers/u

Re: [linux-usb-devel] Make usb quieter during boot

2001-06-06 Thread David Brownell
> During boot, usb produces useless messages. Here's patch to kill them. > > At least I do *not* want my name to spam system screen during boot. Yeah, I had the same reaction. Driver version and description was the compromise I came up with as well. Now, there are just a few other drivers that

[linux-usb-devel] Make usb quieter during boot

2001-06-06 Thread Pavel Machek
Hi! During boot, usb produces useless messages. Here's patch to kill them. At least I do *not* want my name to spam system screen during boot. Pavel --- clean/drivers/usb/acm.c Tue Jun 5 21:37:59 2001 +++ linux/drivers/usb/acm.c