And I really should have slept before posting patches last week-end :(
Anyway, here's one without the obvious bug I had in hcd_unlink_urb().
That's what happens when you do too many things at the same time :(
This time, it's tested on a dual CPU machine with USB kbd and mouse
and these work fine.
Benjamin Herrenschmidt wrote:
And I really should have slept before posting patches last week-end :(
Anyway, here's one without the obvious bug I had in hcd_unlink_urb().
That's what happens when you do too many things at the same time :(
I noticed some of that ... :)
What I'll do is merge the "r
Benjamin Herrenschmidt wrote:
OK, here we go. Enclosed is my current patch that changes some of the
PowerMac specific stuff in a more logical way and get rid of
ohci->sleeping (I didn't get rid of ohci->disabled yet).
So far, suspend & resume with no device plugged works, BUT, once
resumed, I get a
Here's my latest patch that works. You can probably start merging
these, the additionaly cleanups I told you about can wait.
Cheers,
Ben.
diff -urN linux-2.5/drivers/usb/core/hcd-pci.c
linuxppc-2.5-benh/drivers/usb/core/hcd-pci.c
--- linux-2.5/drivers/usb/core/hcd-pci.c2003-08-24 22:34:2
Ok, I confirm that fixing that stupid bug in hcd_irq() makes
things work again, including sleep, but excluding the keyspan
for some other reason (sysfs related ooops I already reported
to Greg, just copied again below just in case you are interested)
keyspan_pda 1-1:0: Keyspan PDA - (prerenumerati
On Sun, 2003-08-24 at 22:00, David Brownell wrote:
> > > Any chance of splitting out the "remove ohci->sleeping" bits
> > > by themselves? If you don't, I'll want to do that.
> >
> >
> > np. I didn't really intent to submit this as a candidate patch, more
> > as a way for you to comment on the d
> Any chance of splitting out the "remove ohci->sleeping" bits
> by themselves? If you don't, I'll want to do that.
np. I didn't really intent to submit this as a candidate patch, more
as a way for you to comment on the direction I'm going.
OK. I'm looking at some stuff there, so far no overlappi
On Sun, 2003-08-24 at 21:30, David Brownell wrote:
> Benjamin Herrenschmidt wrote:
> > OK, here we go. Enclosed is my current patch that changes some of the
> > PowerMac specific stuff in a more logical way and get rid of
> > ohci->sleeping (I didn't get rid of ohci->disabled yet).
> >
> > So far,
OK, here we go. Enclosed is my current patch that changes some of the
PowerMac specific stuff in a more logical way and get rid of
ohci->sleeping (I didn't get rid of ohci->disabled yet).
So far, suspend & resume with no device plugged works, BUT, once
resumed, I get an irq storm of about 20 i
> This is with 2.6.0-test3-latest? I don't think PM itself is
> currently expected to work ... much less any particular driver.
It is 2.6.0-test3-current-linus-bk ;) And yes, PM works for
PowerMacs in my tree and will work in Linus as soon as I have
pushed my pending driver updates.
> There we
Pavel Machek wrote:
Hi!
The new ohci-hcd driver in 2.6 doesn't work for Power Management
on Apple laptops at least. I've studied the code, but since I'm
not very familiar with the whole new hcd architecture, I'm sure
I'm still missing a lot.
This is with 2.6.0-test3-latest? I don't think PM itse
>
> > I'm not entirely sure I like that solution; we didn't need it in 2.4,
> > so it "shouldn't" be needed now.
>
> 2.4 worked sort of "magically" and wasn't very robust on PM if you
> had devices plugged in.
Oh... also 2.4 has those "magic" if (ohci->sleeping) all over the place
and actually
Benjamin Herrenschmidt wrote:
Hi !
The new ohci-hcd driver in 2.6 doesn't work for Power Management
on Apple laptops at least. I've studied the code, but since I'm
not very familiar with the whole new hcd architecture, I'm sure
I'm still missing a lot.
This is with 2.6.0-test3-latest? I don't thi
Hi!
> >It should work. Every time I try to test it its okay... (And every
> >time I try to *use* it, it does something very wrong).
>
> Don't you just hate it when software does that? ;)
I tried screaming "bad computer", and tried telling it that there'll
be no electricity for the supper, but it
Benjamin Herrenschmidt wrote:
I'll do more tests this week-end and see if I can come up with
a patch doing what we said that works (at least with no device
plugged, currently, I get problems even without anything plugged,
but I haven't had much time to dig further than the root hub
problem).
Great
On Fri, 2003-08-22 at 18:53, David Brownell wrote:
> Benjamin Herrenschmidt wrote:
> >
> > Patrick is currently merging a bunch of important PM updates that
> > should help for non-PPC platforms.
>
> I'm pulling Linus' tree right now; seems to have a bunch of them,
> but I wouldn't know if it's b
Benjamin Herrenschmidt wrote:
Patrick is currently merging a bunch of important PM updates that
should help for non-PPC platforms.
I'm pulling Linus' tree right now; seems to have a bunch of them,
but I wouldn't know if it's back to working yet.
I do notice that one part of the patch was to remove
Hi!
> >The new ohci-hcd driver in 2.6 doesn't work for Power Management
> >on Apple laptops at least. I've studied the code, but since I'm
> >not very familiar with the whole new hcd architecture, I'm sure
> >I'm still missing a lot.
>
> This is with 2.6.0-test3-latest? I don't think PM itself i
Hi !
The new ohci-hcd driver in 2.6 doesn't work for Power Management
on Apple laptops at least. I've studied the code, but since I'm
not very familiar with the whole new hcd architecture, I'm sure
I'm still missing a lot.
The big problem with the current code is that it will still access
the chi
19 matches
Mail list logo
