On Tuesday 25 July 2006 2:35 pm, Peter Chubb wrote:
> David> ... in fact, it'd be a good thing to convert rtl8150 to run in
> David> that driver framework, much like asix.c does already. You'd
> David> probably get better throughput too. That's only if you have
> David> the time... :)
>
> We ne
> "David" == David Brownell <[EMAIL PROTECTED]> writes:
>> I get the feeling that your patch does much more testing for
>> -ENODEV than necessary, and likewise for calls to
>> netif_device_detach().
David> Paranoia? :)
Indeed.
>> Do you really have to call that routine from anywhere but th
The patch surely fix the unplug issue so after applying it the driver will
be in better state than it is now. My only micro-addition was to shut off
RX warning that was polluting the kernel log and replace it with dbg().
Greg, please apply.
Petko
On Tue, 25 Jul 2006, Peter
> I get the feeling that your patch does much more testing for -ENODEV than
> necessary, and likewise for calls to netif_device_detach().
Paranoia? :)
> Do you really
> have to call that routine from anywhere but the disconnect() method?
That routine is how the network layer knows not to se
On Tue, 25 Jul 2006, Peter Chubb wrote:
> The RTL8150 driver currently crashes the kernel if the USB lead is unplugged
> while the device is active. The attached patch adds error handling to
> tell the network layer that the device has gone away when the device is
> unplugged. With this patch, t
The RTL8150 driver currently crashes the kernel if the USB lead is unplugged
while the device is active. The attached patch adds error handling to
tell the network layer that the device has gone away when the device is
unplugged. With this patch, the device can be plugged and unplugged
to one's
