[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-05 Thread Ben Collins
On Thu, Jun 05, 2003 at 01:20:15AM -0700, Greg KH wrote: > On Tue, Jun 03, 2003 at 07:33:52PM -0400, Ben Collins wrote: > > Greg, if this doesn't apply to your 2.4.x tree, could you please send me > > an updated tarball of your tree? > > Applied, minus the BUG_ON() part. Thanks. > Do you still w

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-05 Thread Greg KH
On Tue, Jun 03, 2003 at 07:23:35PM -0400, Ben Collins wrote: > > Ben, it looks like your patch broke something for USB keyboards, any > > idea? > > Yep, my patch killed hid-input from scanning HID_OUTPUT_REPORT's. Fixed > with this patch for 2.5.70+bk. I'll send one for 2.4.x in a few minutes. Ap

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-05 Thread Greg KH
On Tue, Jun 03, 2003 at 07:33:52PM -0400, Ben Collins wrote: > Greg, if this doesn't apply to your 2.4.x tree, could you please send me > an updated tarball of your tree? Applied, minus the BUG_ON() part. Do you still want a tarball/patch of my usb 2.4 tree? This patch applied just fine with no

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
Greg, if this doesn't apply to your 2.4.x tree, could you please send me an updated tarball of your tree? --- linux/drivers/usb.new/hid-input.c Thu May 22 22:47:00 2003 +++ linux/drivers/usb/hid-input.c Tue Jun 3 20:35:46 2003 @@ -73,8 +73,11 @@ hidinput = list_entry(lh

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Jordan Breeding
Ben Collins wrote: >>Ben, it looks like your patch broke something for USB keyboards, any >>idea? > > > Yep, my patch killed hid-input from scanning HID_OUTPUT_REPORT's. Fixed > with this patch for 2.5.70+bk. I'll send one for 2.4.x in a few minutes. > > Yup, with that patch in place my keyboar

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
> Ben, it looks like your patch broke something for USB keyboards, any > idea? Yep, my patch killed hid-input from scanning HID_OUTPUT_REPORT's. Fixed with this patch for 2.5.70+bk. I'll send one for 2.4.x in a few minutes. --- linux/drivers/usb/input/hid-input.c 3 Jun 2003 02:53:07 -

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
I've narrowed this down. I'll have a patch shortly. -- Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ Subversion - http://subversion.tigris.org/ Deqo - http://www.deqo.com/ --- This SF.net email is sponsored b

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
On Tue, Jun 03, 2003 at 06:18:13PM -0500, Jordan Breeding wrote: > Ben Collins wrote: > >>Hm, I just tested this on a keyboard here, and can duplicate it. > >> > >>Ben, it looks like your patch broke something for USB keyboards, any > >>idea? > > > > > > My patch alone on 2.4.21-rc4-i386 has work

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
> > Hm, I just tested this on a keyboard here, and can duplicate it. > > Ben, it looks like your patch broke something for USB keyboards, any > idea? My patch alone on 2.4.21-rc4-i386 has working LED's. My patch in your tree that you sent me with 2.4.21-rc6-sparc64 has broken LED's. Veeery inte

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
> Hm, I just tested this on a keyboard here, and can duplicate it. > > Ben, it looks like your patch broke something for USB keyboards, any > idea? No idea. I'm using a USB keyboard in conjunction with the patch. Let me try a 2.5.70+bk build tonight to make sure there were no bad interactions bet

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
> Hm, I just tested this on a keyboard here, and can duplicate it. > > Ben, it looks like your patch broke something for USB keyboards, any > idea? Damn. Surprised I never noticed this. Confirmed even with my 2.4 patches. Give me an hour or so and I'll get you a fix. -- Debian - http://www

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Greg KH
On Tue, Jun 03, 2003 at 01:56:19PM -0700, Greg KH wrote: > On Tue, Jun 03, 2003 at 09:27:05AM -0700, Jordan Breeding wrote: > > Hello, > > > > I have an issue with the two current USB updates -- > > they stop my keyboard LEDs from working properly. I > > run a box with only a USB keyboard and m

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Greg KH
On Tue, Jun 03, 2003 at 09:27:05AM -0700, Jordan Breeding wrote: > Hello, > > I have an issue with the two current USB updates -- > they stop my keyboard LEDs from working properly. I > run a box with only a USB keyboard and mouse attached. > With 2.5.70-mm1 everything works fine, then with >

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Jordan Breeding
Hello, I have an issue with the two current USB updates -- they stop my keyboard LEDs from working properly. I run a box with only a USB keyboard and mouse attached. With 2.5.70-mm1 everything works fine, then with 2.5.70-mm3 (after then main BK branch had picked up some USB updates) the LEDs