On Fri, Jul 25, 2003 at 11:25:29PM +0200, Daniele Bellucci wrote: > > Feedbacks are wellcome > > ... why don't return -ENOMEM on mem. allocation failure in usblp_probe?
We should. I just got some other patches to clean this driver up, look at the linux-usb-devel mailing list for them. This patch is pretty useless: > + if (usblp->statusbuf) > + kfree(usblp->statusbuf); > + if (usblp->device_id_string) > + kfree(usblp->device_id_string); > + if (usblp->writeurb) > + usb_free_urb(usblp->writeurb); > + if (usblp->readurb) > + usb_free_urb(usblp->readurb); Not needed, as we can pass NULL to kfree, and usb_free_usb; thanks, greg k-h ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
