On Mon, Aug 11, 2003 at 06:13:50PM -0700, Jeff Woods wrote:
> Looking only at the above code snippet, I'd suggest something more like:
> + if (!sdp ||
This is not meaningful.
A general kind of convention is that a pointer will be NULL either
by mistake, when it is uninitialized, or on p
On Tue, Aug 12, 2003 at 07:53:53AM +0100, Christoph Hellwig wrote:
> > I see an Oops in the SCSI code, caused by the fact that sdkp is NULL
> > in sd_shutdown. "How can that be?", you will ask - dev->driver_data was set
> > in sd_probe. But in my case sd_probe never finished. An insmod usb-storage
On Tue, Aug 12, 2003 at 07:53:53AM +0100, Christoph Hellwig wrote:
> On Tue, Aug 12, 2003 at 12:28:44AM +0200, Andries Brouwer wrote:
> > I see an Oops in the SCSI code, caused by the fact that sdkp is NULL
> > in sd_shutdown. "How can that be?", you will ask - dev->driver_data was set
> > in sd_pr
On Mon, Aug 11, 2003 at 11:35:26PM -0700, Jeff Woods wrote:
> At +0200 04:49 AM 8/12/2003, Andries Brouwer wrote:
> >On Mon, Aug 11, 2003 at 06:13:50PM -0700, Jeff Woods wrote:
> >
> >>Looking only at the above code snippet, I'd suggest something more like:
> >
> >>+ if (!sdp ||
> >
> >This i
Greg KH [EMAIL PROTECTED] wrote:
> On Tue, Aug 12, 2003 at 07:53:53AM +0100, Christoph Hellwig wrote:
> > On Tue, Aug 12, 2003 at 12:28:44AM +0200, Andries Brouwer wrote:
> > > I see an Oops in the SCSI code, caused by the fact that sdkp is NULL
> > > in sd_shutdown. "How can that be?", you will as
On Tue, Aug 12, 2003 at 12:28:44AM +0200, Andries Brouwer wrote:
> I see an Oops in the SCSI code, caused by the fact that sdkp is NULL
> in sd_shutdown. "How can that be?", you will ask - dev->driver_data was set
> in sd_probe. But in my case sd_probe never finished. An insmod usb-storage
> hangs
At +0200 12:28 AM 8/12/2003, Andries Brouwer wrote (in part):
The obvious patch (with whitespace damage)
diff -u --recursive --new-file -X /linux/dontdiff a/drivers/scsi/sd.c
b/drivers/scsi/sd.c
--- a/drivers/scsi/sd.c Mon Jul 28 05:39:31 2003
+++ b/drivers/scsi/sd.c Tue Aug 12 01:24:51 2003
@@ -
On Tue, Aug 12, 2003 at 05:24:50PM -0700, Mike Anderson wrote:
> > > Well, this same problem could show upb in any other driver. Could
> > > you instead send a patch to Pat that the driver model never calls
> > > the shutdown method for a driver that hasn't finished ->probe?
> >
> > I think it a
At +0200 04:49 AM 8/12/2003, Andries Brouwer wrote:
On Mon, Aug 11, 2003 at 06:13:50PM -0700, Jeff Woods wrote:
Looking only at the above code snippet, I'd suggest something more like:
+ if (!sdp ||
This is not meaningful.
How is it not meaningful? The next action in the expression is to
