Alan Stern wrote:
Have you followed the discussion between me and Jens Axboe recently?  He
pointed out that page_address() shouldn't be used; it should be replaced
by kmap() or kmap_atomic().  There is one such call in
core/message.c:usb_sg_init().  As it stands now, it will probably fail for
sg buffers allocated in high memory.

Only on the PIO path, but you're right that'd be worth fixing to ensure that drivers other than "usbtest" (which always uses kmalloc for its sg buffers) can use it safely.

So far as I know, the only PIO based HCD in use on 2.6 is
"dummy_hcd"; so this doesn't seem a current must-fix issue.
The SL811 support would see this too; but last I heard that
driver wasn't usable on 2.6 for other reasons.

- Dave




------------------------------------------------------- This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/ _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to