Re: [linux-usb-devel] Re: Patch for usbnet with Zaurus

2002-12-16 Thread Alan Cox
On Mon, 2002-12-16 at 20:51, Wolfgang Mües wrote: > Hello Pavel, > > On Sunday 15 December 2002 17:34, Pavel Machek wrote: > > > C++ -style comments should not be used in kernel code. > > Can you point me to this rule? > > It is not mentioned in Documentation/CodingStyle, > and was adopted by

Re: [linux-usb-devel] Re: Patch for usbnet with Zaurus

2002-12-16 Thread Wolfgang Mües
Hello Pavel, On Sunday 15 December 2002 17:34, Pavel Machek wrote: > C++ -style comments should not be used in kernel code. Can you point me to this rule? It is not mentioned in Documentation/CodingStyle, and was adopted by ANSI in 1999. best regards Wolfgang

[linux-usb-devel] Re: Patch for usbnet with Zaurus

2002-12-15 Thread Pavel Machek
Hi! > I've been experimenting with the Zaurus support and have come across two > problems. > The first (patch against 2.4.20 included) is that the tx_fixup adds 6 bytes > for the CRC and padding, but the logic to pad the packet if it is a multiple > of the block size in usbnet_start_xmit is wor

[linux-usb-devel] Re: Patch for usbnet with Zaurus

2002-12-15 Thread Pavel Machek
Hi! > I've been experimenting with the Zaurus support and have come across two > problems. > The first (patch against 2.4.20 included) is that the tx_fixup adds 6 bytes > for the CRC and padding, but the logic to pad the packet if it is a multiple > of the block size in usbnet_start_xmit is wo

[linux-usb-devel] Re: Patch for usbnet with Zaurus

2002-12-14 Thread David Brownell
Toby Milne wrote: Hi, I've been experimenting with the Zaurus support and have come across two problems. Good to hear from you, and great to see the results of your debugging! The first (patch against 2.4.20 included) is that the tx_fixup adds 6 bytes for the CRC and padding, but the logic t