Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-24 Thread David Brownell
Alan Stern wrote: Global suspend is the UHCI equivalent of what you say EHCI and OHCI do automatically: the controller doesn't run and it doesn't do DMA. That's I actually meant that the HCDs do that. Once those parts of the schedule are turned off, the HCDs won't DMA them. But OK, now I know

Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-24 Thread Alan Stern
On Tue, 23 Sep 2003, David Brownell wrote: > Alan Stern wrote: > > > > Sure, a hub (including a virtual root hub) can suspend any of its ports, > > independently. But there's currently no provision in the system for doing > > that. Besides, I think there's a difference between telling an HC t

Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-23 Thread David Brownell
Alan Stern wrote: On Fri, 19 Sep 2003, David Brownell wrote: The tricky bits are recovering from "USB suspend" states ... which I suspect usbcore should help with, to minimize the amount of code to write into each HCD. Can't any hub suspend its ports? There are things that are specific to root h

Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-19 Thread Alan Stern
On Fri, 19 Sep 2003, David Brownell wrote: > Alan Stern wrote: > > > > I wanted to distinguish between two types of suspended states. One is > > where the bus is suspended because no devices are attached, the other is > > where the PM software has told us to suspend. It's necessary to make this

Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-19 Thread David Brownell
Alan Stern wrote: On Tue, 16 Sep 2003, David Brownell wrote: uhci->state = UHCI_SUSPENDED_PM; + uhci->hcd.state = USB_STATE_SUSPENDED; I meant to ask ... why don't you just use uhci->hcd.state exclusively? That's a good question. I wanted to distinguish between two

Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-18 Thread Martin Schwenke
> "Alan" == Alan Stern <[EMAIL PROTECTED]> writes: >> [...] Logs follow... they look a bit different... :-) Alan> Progress, anyway. :-) >> Sep 18 11:16:04 localhost kernel: hub 1-0:0: port 1, status 301, change 1, 1.5 Mb/s Alan> That "change 1" indicates a connection cha

Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-18 Thread Alan Stern
On Thu, 18 Sep 2003, Martin Schwenke wrote: > > "Alan" == Alan Stern <[EMAIL PROTECTED]> writes: > > Alan> Martin, please try again after applying this one-liner on > Alan> top of all those other patches. > > Hmmm... Would you believe no improvement? Logs follow... they look > a b

[linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-17 Thread Martin Schwenke
> "Alan" == Alan Stern <[EMAIL PROTECTED]> writes: Alan> Martin, please try again after applying this one-liner on Alan> top of all those other patches. Hmmm... Would you believe no improvement? Logs follow... they look a bit different... :-) 11:13 suspend 11:16 resume 11:17 /etc

Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-17 Thread Alan Stern
On Tue, 16 Sep 2003, David Brownell wrote: > > > @@ -2531,6 +2531,7 @@ > > if (uhci_active(uhci)) > > suspend_hc(uhci); > > uhci->state = UHCI_SUSPENDED_PM; > > + uhci->hcd.state = USB_STATE_SUSPENDED; > > } > > up(&uhci->state_mutex);

Re: [linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-16 Thread David Brownell
@@ -2531,6 +2531,7 @@ if (uhci_active(uhci)) suspend_hc(uhci); uhci->state = UHCI_SUSPENDED_PM; + uhci->hcd.state = USB_STATE_SUSPENDED; } up(&uhci->state_mutex); return rc; I meant to ask ... why don't

[linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-16 Thread Alan Stern
On Tue, 16 Sep 2003, Martin Schwenke wrote: > > "Alan" == Alan Stern <[EMAIL PROTECTED]> writes: > > [Sorry for the delay in replying - at conference/on vacation...] > > Alan> Here are some changes for UHCI power management. Martin, > Alan> maybe you can try them out and see if they

[linux-usb-devel] Re: UHCI power management patch (as92) for 2.6.0

2003-09-15 Thread Martin Schwenke
> "Alan" == Alan Stern <[EMAIL PROTECTED]> writes: [Sorry for the delay in replying - at conference/on vacation...] Alan> Here are some changes for UHCI power management. Martin, Alan> maybe you can try them out and see if they help with getting Alan> your USB mouse to work after