[linux-usb-devel] Re: usbmon question

2005-11-24 Thread Alan Stern
On Wed, 23 Nov 2005, Pete Zaitcev wrote: > On Tue, 15 Nov 2005 16:08:08 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> > wrote: > > > /* > > * Bulk is easy to shortcut reliably. > > * XXX Other pipe types need consideration. Currently, we overdo it > > * and collect garbage for

[linux-usb-devel] Re: usbmon question

2005-11-23 Thread Pete Zaitcev
On Tue, 15 Nov 2005 16:08:08 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > /* >* Bulk is easy to shortcut reliably. >* XXX Other pipe types need consideration. Currently, we overdo it >* and collect garbage for them: better more than less. >*/ >

[linux-usb-devel] Re: usbmon - document and kill pipe from API

2005-03-24 Thread Greg KH
On Wed, Mar 23, 2005 at 03:44:48PM -0800, Pete Zaitcev wrote: > Someone at linux-usb-devel observed that usbmon should not leak the concept > of pipe to the user space. This patch makes a compromise between having > too many words in the line and the pipe. It breaks API, but I doubt anyone > has an

[linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-23 Thread David Brownell
On Sunday 23 January 2005 5:17 pm, Pete Zaitcev wrote: > On Sun, 23 Jan 2005 15:34:23 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > ... > > > and this is what usbmon intercepts. > > > For one thing, dev is down-counted in usb_unlink_urb(). ^^

[linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-23 Thread Pete Zaitcev
On Sun, 23 Jan 2005 15:34:23 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > so let me restate it. Simply put, neither dev nor hcd are available > > at the time urb->complete is called, > > Completely untrue. They are at a minimum provided through the URB itself, > and giveback (which is t

Re: [linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-23 Thread David Brownell
On Saturday 22 January 2005 12:12 am, Pete Zaitcev wrote: > On Thu, 20 Jan 2005 22:28:31 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > > By the way ... on the topic of usbmon rather than changing > > usbcore, is there a brief writeup of what you want this > > new version to be doing -- and

[linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-22 Thread Pete Zaitcev
On Thu, 20 Jan 2005 22:28:31 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > By the way ... on the topic of usbmon rather than changing > usbcore, is there a brief writeup of what you want this > new version to be doing -- and how? Like, why put the > spy hooks in that location, rather than an

[linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-20 Thread David Brownell
On Thursday 20 January 2005 11:35 am, Pete Zaitcev wrote: > On Wed, 19 Jan 2005 09:08:34 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > I do not like to refer to a dev because I do not quite understand where > the necessary usb_dev_get/_put are now. But if you guarantee that the > urb->dev is r

[linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-20 Thread Pete Zaitcev
On Wed, 19 Jan 2005 09:08:34 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 19 January 2005 7:42 am, Pete Zaitcev wrote: > > Relying on pipe makes > > tests dependant on URB only. No references to bus or HCD, therefore no > > extra refcounts or worries about oopses. Al

[linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-19 Thread David Brownell
On Wednesday 19 January 2005 7:42 am, Pete Zaitcev wrote: > Relying on pipe makes > tests dependant on URB only. No references to bus or HCD, therefore no > extra refcounts or worries about oopses. Also, HC drivers zero out the > urb->dev in giveback sequence which is a royal pain whe

[linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-19 Thread Oliver Neukum
Am Mittwoch, 19. Januar 2005 16:42 schrieb Pete Zaitcev: > On Tue, 18 Jan 2005 22:14:24 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > > > > Also, I don't like the idea of scattering knowledge all over the place > > > > that the root hub is always given address 1 ... > > > > which you didn

[linux-usb-devel] Re: usbmon, usb core, ARM

2005-01-19 Thread Pete Zaitcev
On Tue, 18 Jan 2005 22:14:24 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > > Also, I don't like the idea of scattering knowledge all over the place > > > that the root hub is always given address 1 ... > > which you didn't address yet. Yes, I have to look why you do not like using the pi

[linux-usb-devel] Re: usbmon and usb core

2005-01-18 Thread David Brownell
On Tuesday 18 January 2005 3:07 pm, Pete Zaitcev wrote: > On Tue, 18 Jan 2005 13:51:22 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > > Thereby breaking usb on various systems ... by overwriting the root hub > > status message data as part of bounce buffer handling. NOT a good idea! > > Th

[linux-usb-devel] Re: usbmon and usb core

2005-01-18 Thread Pete Zaitcev
On Tue, 18 Jan 2005 13:51:22 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > Thereby breaking usb on various systems ... by overwriting the root hub > status message data as part of bounce buffer handling. NOT a good idea! > Those patches were added for important reasons. (Or did you add som

Re: [linux-usb-devel] Re: USBMon 0.2a and later

2005-01-18 Thread Stephen J. Gowdy
If it is inline... On Tue, 18 Jan 2005, Matthias Urlichs wrote: > Hi, Stephen J. Gowdy schrub am Tue, 18 Jan 2005 08:17:01 -0800: > [ fullquote of patch ] > > Please Don't Do That. > > -- /+-\ |Stephen J. Gowdy |

[linux-usb-devel] Re: USBMon 0.2a and later

2005-01-18 Thread Matthias Urlichs
Hi, Stephen J. Gowdy schrub am Tue, 18 Jan 2005 08:17:01 -0800: [ fullquote of patch ] Please Don't Do That. -- Matthias Urlichs | {M:U} IT Design @ m-u-it.de | [EMAIL PROTECTED] --- The SF.Net email is sponsored by: Beat the post-

[linux-usb-devel] Re: USBmon

2004-12-16 Thread Harald Welte
On Mon, Dec 13, 2004 at 08:49:22PM -0800, Pete Zaitcev wrote: > Hi, Harald: > > Back in June you mentioned that you use USBmon. I am thinking about giving > this a second look. Where did you get the userland to drive it? There's no > apparent link off linux-usb.org. you don't actually need any us

Re: [linux-usb-devel] Re: USBMon for kernel 2.4.20

2004-06-07 Thread David Brownell
Pete Zaitcev wrote: From that angle, the tracing has to be in fact placed into HC drivers, not into USB core (with attendant increase in overhead, I grant). Placing it into usbfs borders on useless. The USB core might be a good compromise if HC drivers are considered sufficiently solid. That's true

[linux-usb-devel] Re: USBMon for kernel 2.4.20

2004-06-04 Thread Greg KH
On Fri, Jun 04, 2004 at 11:46:42AM -0700, Pete Zaitcev wrote: > On Fri, 4 Jun 2004 10:54:07 -0700 > Greg KH <[EMAIL PROTECTED]> wrote: > > > As you already have the source code for the driver, it's probably much > > easier just to modify the driver to have it spit out what it is doing > > than try

[linux-usb-devel] Re: USBMon for kernel 2.4.20

2004-06-04 Thread Pete Zaitcev
On Fri, 4 Jun 2004 10:54:07 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > As you already have the source code for the driver, it's probably much > easier just to modify the driver to have it spit out what it is doing > than trying to intrepret a USB stream separate from the driver. I do not agree. T