Re: [linux-usb-devel] Unaligned access in EHCI driver

2007-03-05 Thread Greg KH
On Mon, Mar 05, 2007 at 01:40:59PM -0800, David Brownell wrote: > On Thursday 01 March 2007 10:49 pm, Greg KH wrote: > > On Thu, Mar 01, 2007 at 05:45:08PM -0800, David Brownell wrote: > > > On Thursday 01 March 2007 4:20 pm, Max Dmitrichenko wrote: > > > > Hi! > > > > > > > > I get following warn

Re: [linux-usb-devel] Unaligned access in EHCI driver

2007-03-05 Thread David Brownell
On Thursday 01 March 2007 10:49 pm, Greg KH wrote: > On Thu, Mar 01, 2007 at 05:45:08PM -0800, David Brownell wrote: > > On Thursday 01 March 2007 4:20 pm, Max Dmitrichenko wrote: > > > Hi! > > > > > > I get following warnings on spar64: > > > Kernel unaligned access at TPC[1000c9e4] ehci_hub_cont

Re: [linux-usb-devel] Unaligned access in EHCI driver

2007-03-02 Thread Pete Zaitcev
On Fri, 2 Mar 2007 10:22:03 +0300, "Max Dmitrichenko" <[EMAIL PROTECTED]> wrote: > If I understand write, the only place from which the ehci_hub_control > is called is function rh_call_control(). But it passes a pointer to > the buffer allocated on the stack with __attribute__((aligned(4))). > Tha

Re: [linux-usb-devel] Unaligned access in EHCI driver

2007-03-01 Thread Greg KH
On Thu, Mar 01, 2007 at 05:45:08PM -0800, David Brownell wrote: > On Thursday 01 March 2007 4:20 pm, Max Dmitrichenko wrote: > > Hi! > > > > I get following warnings on spar64: > > Kernel unaligned access at TPC[1000c9e4] ehci_hub_control+0x54c/0x68c > > [ehci_hcd] > > > > Despite of the comment

Re: [linux-usb-devel] Unaligned access in EHCI driver

2007-03-01 Thread Pete Zaitcev
On Thu, 1 Mar 2007 21:45:16 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > > > I get following warnings on spar64: > > > Kernel unaligned access at TPC[1000c9e4] ehci_hub_control+0x54c/0x68c > > > [ehci_hcd] > > > > > > Despite of the comment in the patched code, the type cast used there >

Re: [linux-usb-devel] Unaligned access in EHCI driver

2007-03-01 Thread Alan Stern
On Thu, 1 Mar 2007, David Brownell wrote: > On Thursday 01 March 2007 4:20 pm, Max Dmitrichenko wrote: > > Hi! > > > > I get following warnings on spar64: > > Kernel unaligned access at TPC[1000c9e4] ehci_hub_control+0x54c/0x68c > > [ehci_hcd] > > > > Despite of the comment in the patched code,

Re: [linux-usb-devel] Unaligned access in EHCI driver

2007-03-01 Thread David Brownell
On Thursday 01 March 2007 4:20 pm, Max Dmitrichenko wrote: > Hi! > > I get following warnings on spar64: > Kernel unaligned access at TPC[1000c9e4] ehci_hub_control+0x54c/0x68c > [ehci_hcd] > > Despite of the comment in the patched code, the type cast used there > does make unaligned access. The

[linux-usb-devel] Unaligned access in EHCI driver

2007-03-01 Thread Max Dmitrichenko
Hi! I get following warnings on spar64: Kernel unaligned access at TPC[1000c9e4] ehci_hub_control+0x54c/0x68c [ehci_hcd] Despite of the comment in the patched code, the type cast used there does make unaligned access. The fix was made as it's done in ohci-hub.c. --- Best regards, Max diff -bup