Am Montag, 26. März 2007 20:26 schrieb John:
> Hi,
> No, I don't see how it can work.
>
> When a device is disconnected serial_open will
> fail at the very beginning
You are right. All failures must be handled. I'll make a new patch.
> But there may be a more serious problem.
> port is stored i
Hi,
No, I don't see how it can work.
When a device is disconnected serial_open will
fail at the very beginning
(usb_serial_get_by_index returns NULL in my patch
or lock_serial fails in your earlier patch).
In both cases bailout_module_put is bypassed
and ++port->cleaning_up; is not executed.
Hi,
it turns out that tty_open() calls close() even if open() has failed.
As this is undesireable for usb serial drivers, here's a patch
to deal with it.
John, does it fix the issue you reported?
Regards
Oliver
--
--- a/include/linux/usb/serial.h2007-03-26 09:23