Re: [linux-usb-devel] gadget serial driver -- patch for 2.6

2003-10-10 Thread Greg KH
On Thu, Oct 09, 2003 at 01:38:22AM -0500, Al Borchers wrote: > Here is a small patch to bk://kernel.bkbits.net/db/linux/gadget-2.6 > to fix up the "debug defined but not used error message". Thanks, I've applied it. > > clean up error paths > > Do you mean factoring out common error cleanup and

Re: [linux-usb-devel] gadget serial driver -- patch for 2.6

2003-10-08 Thread Al Borchers
Here is a small patch to bk://kernel.bkbits.net/db/linux/gadget-2.6 to fix up the "debug defined but not used error message". Greg KH wrote: > Here's a patch against the latest 2.6 tree that adds the gadget serial > driver. Thanks. > I still think theres some more cleanup that this driver can u

[linux-usb-devel] gadget serial driver timeout fix

2003-10-02 Thread Borchers, Al (C)(STP)
Dave, Greg -- Here is a little patch for gserial.c to fix the timeout while waiting for a condition (used to wait for data to drain on close). This patch applies to the gserial.c file I sent Tuesday night. I sent out a patch last night to add g_serial to bk://kernel.bkbits.net/db/linux/gadget-2.

Re: [linux-usb-devel] gadget serial driver

2003-10-01 Thread David Brownell
Hi, Question: why do you have your own versions of the wait_event() macros? (From on 2.4, or on 2.6 kernels.) The macros are slighty different from linux/sched.h (that is where I got them initially). .. This is a standard "condition variable" kind of synchronization that is described in OS

RE: [linux-usb-devel] gadget serial driver

2003-10-01 Thread Borchers, Al (C)(STP)
David -- > Question: why do you have your own versions of the > wait_event() macros? (From on 2.4, > or on 2.6 kernels.) The macros are slighty different from linux/sched.h (that is where I got them initially). The difference is that these macros expect that the caller has a spin lock, which

Re: [linux-usb-devel] gadget serial driver

2003-10-01 Thread David Brownell
Al Borchers wrote: Greg, David -- Here is a USB gadget serial driver. It talks with Greg's generic USB serial driver on the host side, and it looks like a serial port on the gadget side. Cool, I'm glad to see this! I'll take a look at it; though likely Greg will have more insights from the usb-s