Re: [linux-usb-devel] garmin gps driver patch v0.20

2004-11-08 Thread Hermann Kneissel
Greg, it took me a while since lack of time, but here is a new version v0.22 of the driver (patch for 2.6.10-rc1) > > Not needed, just use module_param() like the other usb-serial drivers do > today. done. > > +/* function prototypes */ > > > > These can be removed by restructuring the code.

Re: [linux-usb-devel] garmin gps driver patch v0.20

2004-10-20 Thread Greg KH
On Tue, Oct 19, 2004 at 08:47:18PM +0200, Hermann Kneissel wrote: > + > +#ifdef CONFIG_USB_SERIAL_DEBUG > + static int debug = 1; > +#else > + static int debug; > +#endif Not needed, just use module_param() like the other usb-serial drivers do today. > +/* function prototypes */ These

[linux-usb-devel] garmin gps driver patch v0.20

2004-10-19 Thread Hermann Kneissel
Here is version 0.20 of the garmin gps driver patch for review, fixing the problems reported by oliver neukum. Hermann Kneissel diff -Naur linux-2.6.9/drivers/usb/serial/garmin_gps.c linux-2.6.9-gps/drivers/usb/serial/garmin_gps.c --- linux-2.6.9/drivers/usb/serial/garmin_gps.c 1970-01-01 01:00