Re: [linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-25 Thread Couriousous
Le Samedi 24 Juin 2006 20:11, Al Viro a écrit : > On Sat, Jun 24, 2006 at 10:38:37AM -0700, Greg KH wrote: > > Ugh, ok, I went back and forth with Andrew on this, before I took it. > > Andrew, any objections to reverting this now? > > Also spelled as "Andrew, could you please RTFS?" > > When we hav

Re: [linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-24 Thread Al Viro
On Sat, Jun 24, 2006 at 06:07:36PM -0400, Alan Stern wrote: > Isn't it obvious what inspired the original report? > > If you don't look very closely at the structure definition you won't > realize that iso_frame_desc is an array. If it were a scalar field then > the patch would have been correc

Re: [linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-24 Thread Alan Stern
On Sat, 24 Jun 2006, Al Viro wrote: > On Sat, Jun 24, 2006 at 10:38:37AM -0700, Greg KH wrote: > > Ugh, ok, I went back and forth with Andrew on this, before I took it. > > Andrew, any objections to reverting this now? > > Also spelled as "Andrew, could you please RTFS?" > > When we have > > st

Re: [linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-24 Thread Al Viro
On Sat, Jun 24, 2006 at 10:38:37AM -0700, Greg KH wrote: > Ugh, ok, I went back and forth with Andrew on this, before I took it. > Andrew, any objections to reverting this now? Also spelled as "Andrew, could you please RTFS?" When we have struct foo { struct bar array[0]; }; str

Re: [linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-24 Thread Greg KH
On Sat, Jun 24, 2006 at 04:27:00PM +0100, Al Viro wrote: > commit 786dc1d3d7333f269e17d742886eac2188a2d9cc > Author: Philippe Retornaz <[EMAIL PROTECTED]> > Date: Thu Jun 1 20:48:46 2006 -0700 > > [PATCH] usb: drivers/usb/core/devio.c dereferences a userspace pointer > > See http://

[linux-usb-devel] please, revert 786dc1d3d7333f269e17d742886eac2188a2d9cc

2006-06-24 Thread Al Viro
commit 786dc1d3d7333f269e17d742886eac2188a2d9cc Author: Philippe Retornaz <[EMAIL PROTECTED]> Date: Thu Jun 1 20:48:46 2006 -0700 [PATCH] usb: drivers/usb/core/devio.c dereferences a userspace pointer See http://bugzilla.kernel.org/show_bug.cgi?id=6617. This function derefe