Re: [linux-usb-devel] usb: free DMA if enqueue fails

2007-06-08 Thread Greg KH
On Fri, Jun 08, 2007 at 01:26:43PM -0700, Pete Zaitcev wrote: > On Fri, 8 Jun 2007 12:37:46 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > > > Hm, as it's now purged from my wueue, can you resend it? Sorry if I > > missed the fact that it looked correct :( > > Will do in a moment. I thought that re

Re: [linux-usb-devel] usb: free DMA if enqueue fails

2007-06-08 Thread Pete Zaitcev
On Fri, 8 Jun 2007 12:37:46 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > Hm, as it's now purged from my wueue, can you resend it? Sorry if I > missed the fact that it looked correct :( Will do in a moment. I thought that re-sending exactly same patch would piss you off, but didn't know how to cor

Re: [linux-usb-devel] usb: free DMA if enqueue fails

2007-06-08 Thread Greg KH
On Fri, Jun 08, 2007 at 12:15:30PM -0700, Pete Zaitcev wrote: > On Fri, 8 Jun 2007 11:58:47 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > > > Care to resend this with the needed signed-off-by and good changelog > > entry? > > What was wrong with "Release DMA resources if submission fails in > the H

Re: [linux-usb-devel] usb: free DMA if enqueue fails

2007-06-08 Thread Pete Zaitcev
On Fri, 8 Jun 2007 11:58:47 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > Care to resend this with the needed signed-off-by and good changelog > entry? What was wrong with "Release DMA resources if submission fails in the HCD."? Maybe you want me to elaborate on the condition under which it can fai

Re: [linux-usb-devel] usb: free DMA if enqueue fails

2007-06-08 Thread Greg KH
On Fri, Jun 01, 2007 at 03:29:56PM -0400, Alan Stern wrote: > On Fri, 1 Jun 2007, Pete Zaitcev wrote: > > > Just for the record, I didn't find it just by looking. IBM filed a bug > > RH#236922 after they ran out of IOMMU. Our (older) uhci-hcd was rejecting > > bulk requests sent to interrupt endpo

Re: [linux-usb-devel] usb: free DMA if enqueue fails

2007-06-01 Thread Alan Stern
On Fri, 1 Jun 2007, Pete Zaitcev wrote: > Just for the record, I didn't find it just by looking. IBM filed a bug > RH#236922 after they ran out of IOMMU. Our (older) uhci-hcd was rejecting > bulk requests sent to interrupt endpoints, so running their management > application on the GA kernel deple

Re: [linux-usb-devel] usb: free DMA if enqueue fails

2007-06-01 Thread Pete Zaitcev
Release DMA resources if submission fails in the HCD. Signed-Off-By: Pete Zaitcev <[EMAIL PROTECTED]> --- > Amazing indeed. Just for the record, I didn't find it just by looking. IBM filed a bug RH#236922 after they ran out of IOMMU. Our (older) uhci-hcd was rejecting bulk requests sent to inte

Re: [linux-usb-devel] usb: free DMA if enqueue fails

2007-06-01 Thread Alan Stern
On Thu, 31 May 2007, Pete Zaitcev wrote: > Release DMA resources if submission fails in the HCD. > > Signed-Off-By: Pete Zaitcev <[EMAIL PROTECTED]> > > --- > > This seems too obvious. Yet I went back to kernel 2.2.19 and we always > had this bug (well, in 2.2 we didn't because we used virt_to_

[linux-usb-devel] usb: free DMA if enqueue fails

2007-05-31 Thread Pete Zaitcev
Release DMA resources if submission fails in the HCD. Signed-Off-By: Pete Zaitcev <[EMAIL PROTECTED]> --- This seems too obvious. Yet I went back to kernel 2.2.19 and we always had this bug (well, in 2.2 we didn't because we used virt_to_bus). I'm amazed that such things can lay in plain view fo