Re: [linux-usb-devel] Patch for 2.6 file_storage.c

2004-07-28 Thread Alan Stern
On Tue, 27 Jul 2004, David Brownell wrote: > Alan Stern wrote: > > > What do you think about the problem of stalling the bulk-out endpoint when > > the host sends too much data? Maybe this hasn't caused you any > > difficulty yet. The problem is that there's a race. > > What'd be the conseq

RE: [linux-usb-devel] Patch for 2.6 file_storage.c

2004-07-28 Thread Alan Stern
On Tue, 27 Jul 2004, Todd Fischer wrote: > Since there is a race condition, I would recommend changing the code where > the race condition occurs to get rid of it forever. Using the no-stall > option my cause reasonable use of stall to be disabled as well. > > Also, on the Linux 2.4 driver, it s

Re: [linux-usb-devel] Patch for 2.6 file_storage.c

2004-07-27 Thread David Brownell
Alan Stern wrote: What do you think about the problem of stalling the bulk-out endpoint when the host sends too much data? Maybe this hasn't caused you any difficulty yet. The problem is that there's a race. What'd be the consequence of just not using bulk stalls? - Dave

RE: [linux-usb-devel] Patch for 2.6 file_storage.c

2004-07-27 Thread Todd Fischer
> -Original Message- > From: Diego Dompe [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 27, 2004 2:42 PM > To: Alan Stern > > > What do you think about the problem of stalling the bulk-out > endpoint when > > the host sends too much data? Maybe this hasn't caused you any > > difficulty

Re: [linux-usb-devel] Patch for 2.6 file_storage.c

2004-07-27 Thread Diego Dompe
Alan, On Tue, 2004-07-27 at 15:49 -0400, Alan Stern wrote: > That's a problem in the controller driver. Which driver are you using? > It should include something like this in its usb_gadget_register_driver() > routine (this is copied from net2280.c): > > dev->gadget.dev.driver = &driver

Re: [linux-usb-devel] Patch for 2.6 file_storage.c

2004-07-27 Thread Alan Stern
On Tue, 27 Jul 2004, Diego Dompe wrote: > The driver registration logic was producing the kernel to get NULL > pointer references. See below. > > You moved the code that registers the LUN devices into > > fsg_bind(). This change looks correct; although there is > > a comment stating

Re: [linux-usb-devel] Patch for 2.6 file_storage.c

2004-07-27 Thread Diego Dompe
Hi Alan, > What was wrong with the registration logic and how did it crash your > kernel? In your patch I see two changes: The driver registration logic was producing the kernel to get NULL pointer references. > You moved the code that registers the LUN devices into > fsg_bind().

Re: [linux-usb-devel] Patch for 2.6 file_storage.c

2004-07-27 Thread Alan Stern
On Tue, 27 Jul 2004, Todd Fischer wrote: > Hi, > > We ran into a few problems trying to use file backed storage on 2.6. What were your problems? > Attached is the patch file to the 1.9 version of the Linux 2.6 > file_storage.c file, which makes the following changes: > > - Fix the registration