On Thu, 28 Sep 2006, David Brownell wrote:
> On Thursday 28 September 2006 5:20 pm, Andrew Morton wrote:
> > On Thu, 28 Sep 2006 17:08:33 -0700
> > David Brownell <[EMAIL PROTECTED]> wrote:
> >
> > > ... reviewing and testing those new OHCI changes is still on my
> > > list;
> >
> > erm, we pref
Andrew Morton <[EMAIL PROTECTED]> wrote:
[...]
> That's the "some gccs dont like static function decls in that scope" thing.
>
> I fixed it (unpleasantly) like this:
>
>
> diff -puN drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack
> drivers/usb/host/ohci-hub.c
> --- a/drivers/
On Thursday 28 September 2006 5:20 pm, Andrew Morton wrote:
> On Thu, 28 Sep 2006 17:08:33 -0700
> David Brownell <[EMAIL PROTECTED]> wrote:
>
> > ... reviewing and testing those new OHCI changes is still on my
> > list;
>
> erm, we prefer to do that before code hits mainline.
Exactly why I ment
On Thu, 28 Sep 2006 17:08:33 -0700
David Brownell <[EMAIL PROTECTED]> wrote:
> > --- a/drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack
> > +++ a/drivers/usb/host/ohci-hub.c
> > @@ -132,6 +132,10 @@ static inline struct ed *find_head (stru
> > return ed;
> > }
> >
> > +#ifde
On Thu, 28 Sep 2006 17:05:24 -0700
Greg KH <[EMAIL PROTECTED]> wrote:
> >
> > +#ifdef CONFIG_PM
> > +static int ohci_restart(struct ohci_hcd *ohci);
> > +#endif
>
> That #ifdef shouldn't be even needed.
We'll get "warning: 'ohci_restart' declared 'static' but never defined"
without it.
--
> --- a/drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack
> +++ a/drivers/usb/host/ohci-hub.c
> @@ -132,6 +132,10 @@ static inline struct ed *find_head (stru
> return ed;
> }
>
> +#ifdef CONFIG_PM
> +static int ohci_restart(struct ohci_hcd *ohci);
> +#endif
> +
> /* caller
On Thu, Sep 28, 2006 at 05:05:24PM -0700, Greg KH wrote:
> On Thu, Sep 28, 2006 at 04:59:51PM -0700, Andrew Morton wrote:
> > On Thu, 28 Sep 2006 16:40:23 -0700 (PDT)
> > Linus Torvalds <[EMAIL PROTECTED]> wrote:
> >
> > >
> > >
> > > On Thu, 28 Sep 2006, Greg KH wrote:
> > > >
> > > > Here are
On Thu, Sep 28, 2006 at 04:59:51PM -0700, Andrew Morton wrote:
> On Thu, 28 Sep 2006 16:40:23 -0700 (PDT)
> Linus Torvalds <[EMAIL PROTECTED]> wrote:
>
> >
> >
> > On Thu, 28 Sep 2006, Greg KH wrote:
> > >
> > > Here are some more USB bugfixes and device ids 2.6.18. They should all
> > > fix th
On Thu, 28 Sep 2006 16:40:23 -0700 (PDT)
Linus Torvalds <[EMAIL PROTECTED]> wrote:
>
>
> On Thu, 28 Sep 2006, Greg KH wrote:
> >
> > Here are some more USB bugfixes and device ids 2.6.18. They should all
> > fix the reported problems in your current tree (if not, please let me
> > know.)
> >
>
On Thu, Sep 28, 2006 at 04:40:23PM -0700, Linus Torvalds wrote:
>
>
> On Thu, 28 Sep 2006, Greg KH wrote:
> >
> > Here are some more USB bugfixes and device ids 2.6.18. They should all
> > fix the reported problems in your current tree (if not, please let me
> > know.)
> >
> > All of these chan
On Thu, 28 Sep 2006, Greg KH wrote:
>
> Here are some more USB bugfixes and device ids 2.6.18. They should all
> fix the reported problems in your current tree (if not, please let me
> know.)
>
> All of these changes have been in the -mm tree for a while.
Maybe I shouldn't have hurried you.
11 matches
Mail list logo
