Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-16 Thread David Brownell
On Wednesday 16 March 2005 8:00 am, Alan Stern wrote: > On Wed, 16 Mar 2005 [EMAIL PROTECTED] wrote: > > > The problem is not reference counting the problem is some code in > > driver/base/bus.c. First I will describe the scenario: I suppose your theory for why usbnet/cdc doesn't hit this is: >

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-16 Thread Greg KH
On Wed, Mar 16, 2005 at 11:00:02AM -0500, Alan Stern wrote: > Greg, I've got some pretty good ideas about how to do it. But they're not > fully developed and I need help settling some issues. What's a good > mailing list to discuss these things on? LKML? lkml works for me, just make sure to CC:

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-16 Thread Alan Stern
On Wed, 16 Mar 2005 [EMAIL PROTECTED] wrote: > The problem is not reference counting the problem is some code in > driver/base/bus.c. First I will describe the scenario: > All is well and we call the driver remove function which calls > acm_disconnect. acm_disconnect calls usb_driver_release_int

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-16 Thread brm
Brian Murphy <[EMAIL PROTECTED]> said: > Alan Stern wrote: > > >On Mon, 14 Mar 2005, Brian Murphy wrote: > > > > > > > >>This was nice in theory and partially fixes the problem (no more crash) > >>unfortunately > >>the module removal hangs if the data interface is attempted to be > >>removed

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-15 Thread Alan Stern
On Tue, 15 Mar 2005, Brian Murphy wrote: > Yes. I'll look at it tomorrow. If you have any ideas about a good place > to look then > that might save me some time. Considering what David Brownell said, I'd start looking in the driver itself. I usually add printks to display the important refcount

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-14 Thread Brian Murphy
Alan Stern wrote: On Mon, 14 Mar 2005, Brian Murphy wrote: This was nice in theory and partially fixes the problem (no more crash) unfortunately the module removal hangs if the data interface is attempted to be removed first. This seems to be because usb_driver_claim_interface is not the same

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-14 Thread David Brownell
On Monday 14 March 2005 7:57 am, Brian Murphy wrote: > Brian Murphy wrote: > > This seems to be because usb_driver_claim_interface is not the same as > claiming the interface in the probe routine causing the call to > usb_driver_release_interface to not decrement some reference > count somewher

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-14 Thread Oliver Neukum
Am Montag, 14. März 2005 16:57 schrieb Brian Murphy: > The best fix I have found so far is to detect if the disconnect function > is called first > with the data interface and just return without doing anything, waiting > to be called > with the control interface (see attached patch).  This fixes

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-14 Thread Alan Stern
On Mon, 14 Mar 2005, Brian Murphy wrote: > This was nice in theory and partially fixes the problem (no more crash) > unfortunately > the module removal hangs if the data interface is attempted to be > removed first. > > This seems to be because usb_driver_claim_interface is not the same as > c

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-14 Thread Brian Murphy
Brian Murphy wrote: Oliver Neukum wrote: Could you make a single patch for that? Regards Oliver Here are the patches resubmitted with the exporting of symbols split off to a seperate patch. /Brian Make sure th

Re: [linux-usb-devel] [PATCH] 1/3 cdc acm errors

2005-03-13 Thread Brian Murphy
Oliver Neukum wrote: Could you make a single patch for that? Regards Oliver Here are the patches resubmitted with the exporting of symbols split off to a seperate patch. /Brian Make sure the cdc acm driver frees its two interfaces only once independant of the order they a