Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

2007-07-03 Thread Greg KH
On Wed, Jul 04, 2007 at 10:31:10AM +0800, linlei 60022748 wrote: > > Hello Greg, > > Will you accept it? Accept what? I thought you should redo the patch based on all of the comments so far, right? If you do that, then yes, I will. thanks, greg k-h --

Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

2007-07-03 Thread linlei 60022748
Hello Greg, Will you accept it? best wishes Linlei Huawei Technologies Wireless Terminal R&D Dept - 原邮件 - 发件人: linlei 60022748 <[EMAIL PROTECTED]> 日期: 星期二, 六月 26日, 2007 下午4:06 主题: Re: [linux-usb-devel][PATCH] Active Huawei E220 devs > Phil, > Thank you for accept th

Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

2007-06-26 Thread Phil Dibowitz
On Tue, Jun 26, 2007 at 08:57:08AM -0700, Matthew Dharm wrote: > > -UNUSUAL_DEV( 0x12d1, 0x1003, 0x, 0x, > > +UNUSUAL_DEV( 0x12d1, 0x1003, 0x, 0x, > > Do you really want a device range from 0 to 0? Generally speaking, I ask people to only include devices that actually exist and ne

Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

2007-06-26 Thread Matthew Dharm
On Tue, Jun 26, 2007 at 04:06:38PM +0800, linlei 60022748 wrote: > diff -urN -X linux-2.6.21.1-vanilla/Documentation/dontdiff > linux-2.6.21.1-vanilla/drivers/usb/storage/initializers.h > linux-2.6.21.1/drivers/usb/storage/initializers.h > --- linux-2.6.21.1-vanilla/drivers/usb/storage/initialize

Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

2007-06-26 Thread Alan Stern
On Tue, 26 Jun 2007, linlei 60022748 wrote: > Phil, > Thank you for accept the unusual_devs.h portion of the previous patch. > > Greg, > This is the updated patch, please check it. > +/* This places the HUAWEI E220 devices in multi-port mode */ > +int usb_stor_switch_ports_init(struct us_data *

Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

2007-06-26 Thread linlei 60022748
Phil, Thank you for accept the unusual_devs.h portion of the previous patch. Greg, This is the updated patch, please check it. best wishes Linlei Huawei Technologies Wireless Terminal R&D Dept This patch make the HUAWEI E220 device to map out three ports instead of only one virtural cd por

Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

2007-06-25 Thread Phil Dibowitz
linlei 60022748 wrote: > Hi there, > This patch make the HUAWEI E220 device to map out three ports instead of only > one virtural cd port. > See the patch for the full explanation, CC's, and sign-off. And please apply. Short of Greg's point that the return status of usb_control_msg() isn't checke

Re: [linux-usb-devel] [PATCH] Active Huawei E220 devs

2007-06-25 Thread Greg KH
On Mon, Jun 25, 2007 at 08:16:44PM +0800, linlei 60022748 wrote: > Hi there, > This patch make the HUAWEI E220 device to map out three ports instead of only > one virtural cd port. > See the patch for the full explanation, CC's, and sign-off. And please apply. Shouldn't you check the return value