Re: [linux-usb-devel] error handling in tty_open

2007-03-26 Thread Oliver Neukum
Am Montag, 26. März 2007 20:26 schrieb John: > Hi, > No, I don't see how it can work. > > When a device is disconnected serial_open will > fail at the very beginning You are right. All failures must be handled. I'll make a new patch. > But there may be a more serious problem. > port is stored i

Re: [linux-usb-devel] error handling in tty_open

2007-03-26 Thread John
Hi, No, I don't see how it can work. When a device is disconnected serial_open will fail at the very beginning (usb_serial_get_by_index returns NULL in my patch or lock_serial fails in your earlier patch). In both cases bailout_module_put is bypassed and ++port->cleaning_up; is not executed.