[linux-usb-devel] cdc-acm patch for debug messages

2006-05-16 Thread Alexander V. Lukyanov
Here is a patch to correct debug messages in cdc-acm driver. The problem is that dbg automatically appends \n, so the extra newline character gets logged with wrong level and thus is output to console. --- cdc-acm.c.1 2006-05-14 00:21:57.0 +0400 +++ cdc-acm.c 2006-05-14

Re: [linux-usb-devel] Re: 2.6.16: usb modem (cdc-acm driver) and duplicate bytes

2006-05-16 Thread Alexander V. Lukyanov
On Sat, May 13, 2006 at 09:32:50AM +0200, Oliver Neukum wrote: Unfortunately there's no hint in the descriptors. I've just used the device id. Could you test the attached version? It works nicely. But I don't quite understand the *2 multiplier for readsize. Is it correct to request more data

Re: [linux-usb-devel] Re: 2.6.16: usb modem (cdc-acm driver) and duplicate bytes

2006-05-13 Thread Alexander V. Lukyanov
On Tue, May 09, 2006 at 11:52:36PM +0200, Oliver Neukum wrote: In the `n1' case the second attempt of atv results in a duplicated line. `n16' produces lots of small dups. `old' produces no dups. Could you please remobe #undef DEBUG from the driver and rerun the n=1 test? Typescript and

Re: [linux-usb-devel] Re: 2.6.16: usb modem (cdc-acm driver) and duplicate bytes

2006-05-12 Thread Alexander V. Lukyanov
On Fri, May 12, 2006 at 07:31:37PM +0200, Oliver Neukum wrote: Very good. It seems that all corrupted buffers have a length of 128. Could you remove the multiplicator *2 from this line: readsize = le16_to_cpu(epread-wMaxPacketSize)*2; and retest? That's it! Now with NRU=NRB=1 it works

Re: [linux-usb-devel] Re: 2.6.16: usb modem (cdc-acm driver) and duplicate bytes

2006-05-09 Thread Alexander V. Lukyanov
On Sat, May 06, 2006 at 10:23:05AM +0200, Oliver Neukum wrote: Am Samstag, 6. Mai 2006 07:20 schrieben Sie: On Sat, May 06, 2006 at 12:05:42AM +0200, Oliver Neukum wrote: It might be that your modem cannot cope with the ring buffer patch that went into 2.6.16. Can you revert a specific

Re: [linux-usb-devel] Re: 2.6.16: usb modem (cdc-acm driver) and duplicate bytes

2006-05-09 Thread Alexander V. Lukyanov
On Tue, May 09, 2006 at 07:19:08PM +0200, Oliver Neukum wrote: Very good. It seems that something in your system cannot cope with higher speeds of the 2.6.16 driver. Could you please take the 2.6.16 driver and half the values of ACM_NRU and ACM_NRB in cdc-acm.h until you find a value that

Re: [linux-usb-devel] Re: 2.6.16: usb modem (cdc-acm driver) and duplicate bytes

2006-05-05 Thread Alexander V. Lukyanov
On Mon, May 01, 2006 at 02:11:54PM -0700, Pete Zaitcev wrote: Could you get a usbmon trace or something? I cannot make any sense from these messages. Even if I did, it's hard to correlate them to your duplicates. Ok, here is usbmon trace and corresponding chat log. In this case a three byte

[linux-usb-devel] Re: 2.6.16: usb modem (cdc-acm driver) and duplicate bytes

2006-05-01 Thread Alexander V. Lukyanov
On Fri, Apr 21, 2006 at 10:22:46AM +0400, Alexander V. Lukyanov wrote: It appears that the duplicate data are coming from a lower level of usb drivers, but I have not taken a look there yet. Here are some more debug messages. I'm still not sure what causes the duplicates, driver or modem

[linux-usb-devel] [2.6.10] cdc-acm.c patches

2005-02-18 Thread Alexander V. Lukyanov
Hello! I have ZyXEL UNO modem which has usb acm interface. Starting with kernel version 2.6.8 the driver cdc-acm began to hand when the modem connection was dropped due to being idle. After the hang, no data could be read from the device /dev/usb/ttyACM0, but writting was ok. The led data was lit